httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randy Kobes <ra...@theoryx5.uwinnipeg.ca>
Subject RE: prepared 0.32 for release
Date Tue, 03 Apr 2001 17:43:29 GMT
On Tue, 3 Apr 2001, Doug MacEachern wrote:

> On Tue, 3 Apr 2001, Geoffrey Young wrote:
> 
> > Request.xs: In function `XS_Apache__Upload_fh':
> > Request.xs:382: warning: assignment from incompatible pointer type
> > 
> > doesn't seem to affect anything though...
> 
> you mean not including the core dump it triggers? ;)
> 
> if PerlIO is defined, PerlIO_importFILE will be available as a function,
> but it was being redefined.  this patch fixes for me..
> 
> Index: Request/Request.xs
> ===================================================================
> RCS file: /home/cvs/httpd-apreq/Request/Request.xs,v
> retrieving revision 1.12
> diff -u -r1.12 Request.xs
> --- Request/Request.xs	2001/03/15 03:04:11	1.12
> +++ Request/Request.xs	2001/04/03 16:27:09
> @@ -87,9 +87,6 @@
>  
>  #ifdef PerlIO
>  typedef PerlIO * InputStream;
> -#ifndef PerlIO_importFILE
> -#define PerlIO_importFILE(fp,flags) ((FILE *)fp)
> -#endif
>  #else
>  typedef FILE * InputStream;
>  #define PerlIO_importFILE(fp,flags) fp
> 

I don't have access to my Win32 machine at the moment, but
when I was looking at this before, without the

 #ifndef PerlIO_importFILE
 #define PerlIO_importFILE(fp,flags) ((FILE *)fp)
 #endif

I got an error about PerlIO_importFILE not being found - this 
was with ActivePerl 623, which has the defines for multi-thread.
On a self-compiled Win32 perl without multi-thread, it found
PerlIO_importFILE OK, without the need for this check. 
At the time I thought it related to PERL_IMPLICIT_SYS being defined 
for ActivePerl - if instead of the above check I put at the top 
of Request.xs

#undef PERL_IMPLICIT_SYS

then PerlIO_importFILE was found OK on ActivePerl.

best regards,
randy


Mime
View raw message