Return-Path: Mailing-List: contact apreq-dev-help@httpd.apache.org; run by ezmlm Delivered-To: mailing list apreq-dev@httpd.apache.org Received: (qmail 59496 invoked from network); 24 Feb 2001 17:29:32 -0000 Received: from mail5.mia.bellsouth.net (205.152.144.17) by h31.sny.collab.net with SMTP; 24 Feb 2001 17:29:32 -0000 Received: from mumonkan.sunstarsys.com (adsl-78-194-118.mia.bellsouth.net [216.78.194.118]) by mail5.mia.bellsouth.net (3.3.5alt/0.75.2) with ESMTP id MAA18622; Sat, 24 Feb 2001 12:35:34 -0500 (EST) Received: (from joe@localhost) by mumonkan.sunstarsys.com (8.11.0/8.11.0) id f1OHUFG19127; Sat, 24 Feb 2001 12:30:16 -0500 Sender: joe@sunstarsys.com To: Matt Sergeant Cc: "David N. Welton" , "apreq-dev@httpd.apache.org" Subject: Re: Sun Workshop C compilation patch References: From: Joe Schaefer Date: 24 Feb 2001 12:30:15 -0500 In-Reply-To: Matt Sergeant's message of "Sat, 24 Feb 2001 12:12:36 +0000 (GMT)" Message-ID: Lines: 36 User-Agent: Gnus/5.0802 (Gnus v5.8.2) Emacs/20.5 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N Matt Sergeant writes: > On 20 Feb 2001, David N. Welton wrote: > > > > > A mod_dtcl user sent me this. Why are these included but not used? > > > > --- apache_multipart_buffer.c~ Mon Feb 19 19:37:57 2001 > > +++ apache_multipart_buffer.c Mon Feb 19 19:38:55 2001 > > @@ -182,7 +182,6 @@ > > /* finds a boundary */ > > int find_boundary(multipart_buffer *self, char *boundary) > > { > > - int len, bound_len = strlen(boundary); > > char *line; > > > > /* loop thru lines */ > > No idea... > > BTW: since nobody responded to my last patch, or this one, I'm thinking of > just commiting the patches. Does anyone have any immediate worry about > that? No, but I'd rather patch the whole thing with the code I wrote using the list.c,h stuff and building from there instead. But since there's no consensus regarding whether or not it's a good idea, I've been keeping quiet about it. btw- the other patch you posted looked good to me. -- Joe Schaefer joe@sunstarsys.com