httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Schaefer <...@sunstarsys.com>
Subject Re: Sun Workshop C compilation patch
Date Sat, 24 Feb 2001 17:30:15 GMT
Matt Sergeant <matt@sergeant.org> writes:

> On 20 Feb 2001, David N. Welton wrote:
> 
> >
> > A mod_dtcl user sent me this.  Why are these included but not used?
> >
> > --- apache_multipart_buffer.c~  Mon Feb 19 19:37:57 2001
> > +++ apache_multipart_buffer.c   Mon Feb 19 19:38:55 2001
> > @@ -182,7 +182,6 @@
> >   /* finds a boundary */
> >   int find_boundary(multipart_buffer *self, char *boundary)
> >   {
> > -    int len, bound_len = strlen(boundary);
> >       char *line;
> >
> >       /* loop thru lines */
> 
> No idea...
> 
> BTW: since nobody responded to my last patch, or this one, I'm thinking of
> just commiting the patches. Does anyone have any immediate worry about
> that?

No, but I'd rather patch the whole thing with the code I wrote using 
the list.c,h stuff and building from there instead.  But since there's 
no consensus regarding whether or not it's a good idea, I've been
keeping quiet about it.


btw- the other patch you posted looked good to me.

-- 
Joe Schaefer
joe@sunstarsys.com


Mime
View raw message