Return-Path: Mailing-List: contact apreq-dev-help@httpd.apache.org; run by ezmlm Delivered-To: mailing list apreq-dev@httpd.apache.org Delivered-To: moderator for apreq-dev@httpd.apache.org Received: (qmail 95286 invoked from network); 14 Dec 2000 04:21:05 -0000 Received: from mail0.mia.bellsouth.net (205.152.144.12) by locus.apache.org with SMTP; 14 Dec 2000 04:21:05 -0000 Received: from mumonkan.sunstarsys.com (adsl-61-20-87.mia.bellsouth.net [208.61.20.87]) by mail0.mia.bellsouth.net (3.3.5alt/0.75.2) with ESMTP id XAA27086 for ; Wed, 13 Dec 2000 23:21:02 -0500 (EST) Received: (from joe@localhost) by mumonkan.sunstarsys.com (8.11.0/8.11.0) id eBE4L2P05176; Wed, 13 Dec 2000 23:21:02 -0500 Sender: joe@sunstarsys.com To: apreq-dev@httpd.apache.org Subject: Re: libapreq (preliminary comments on the multipart.c code) References: <20001204134112.H2163@trainedmonkey.com> <20001204155853.A10307@trainedmonkey.com> <20001207232843.D6765@trainedmonkey.com> <20001211200700.I10228@trainedmonkey.com> From: Joe Schaefer Date: 13 Dec 2000 23:21:02 -0500 In-Reply-To: Joe Schaefer's message of "11 Dec 2000 22:33:20 -0500" Message-ID: Lines: 21 User-Agent: Gnus/5.0802 (Gnus v5.8.2) Emacs/20.5 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N Joe Schaefer writes: > There's still something that I haven't groked yet about how the > multipart_buffer_read code works on boundary reads. As I can't come > up with a real test page that breaks it, perhaps you could set me > straight on how it handles partial boundary reads. [ snip slightly misleading picture ] > As I said, I can't produce this behavior with a real example, so > I'm probably missing something. I guess I'm just skeptical > that partial boundary matches actually work right in exceptional > cases like this. I got it now- my picture was wrong. You don't modify self->buffer at all- just the copied version in buf. Very slick and efficient- I'm no longer a skeptic :) -- Joe Schaefer