httpd-apreq-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@apache.org
Subject svn commit: r216197 - in /httpd/apreq/trunk: CHANGES glue/perl/xsbuilder/apreq_xs_postperl.h
Date Wed, 13 Jul 2005 17:41:23 GMT
Author: joes
Date: Wed Jul 13 10:41:22 2005
New Revision: 216197

URL: http://svn.apache.org/viewcvs?rev=216197&view=rev
Log:

Fix "Attempt to free temp prematurely" bug in apreq_xs_error().
The reason is that Perl_load_module() "magically frees" the 
two SVs; notably pkg_name.

Submitted by: Philip M. Gollucci
Message-ID: <42D4C392.3030708@p6m7g8.com>
Reviewed by: joes

Modified:
    httpd/apreq/trunk/CHANGES
    httpd/apreq/trunk/glue/perl/xsbuilder/apreq_xs_postperl.h

Modified: httpd/apreq/trunk/CHANGES
URL: http://svn.apache.org/viewcvs/httpd/apreq/trunk/CHANGES?rev=216197&r1=216196&r2=216197&view=diff
==============================================================================
--- httpd/apreq/trunk/CHANGES (original)
+++ httpd/apreq/trunk/CHANGES Wed Jul 13 10:41:22 2005
@@ -4,6 +4,10 @@
 
 @section v2_06 Changes with libapreq2-2.06
 
+
+- Perl API [Philip M. Gollucci]
+  Fix "Attempt to free temp prematurely" error in apreq_xs_croak().
+
 - C API [Philip M. Gollucci]
   Add mod_apreq2 to httpd's server tokens.
 

Modified: httpd/apreq/trunk/glue/perl/xsbuilder/apreq_xs_postperl.h
URL: http://svn.apache.org/viewcvs/httpd/apreq/trunk/glue/perl/xsbuilder/apreq_xs_postperl.h?rev=216197&r1=216196&r2=216197&view=diff
==============================================================================
--- httpd/apreq/trunk/glue/perl/xsbuilder/apreq_xs_postperl.h (original)
+++ httpd/apreq/trunk/glue/perl/xsbuilder/apreq_xs_postperl.h Wed Jul 13 10:41:22 2005
@@ -243,7 +243,7 @@
 
     stash = gv_stashpv(ERROR_CLASS, FALSE);
     if (stash == NULL) {
-        SV *pkg_name = sv_2mortal(newSVpv(class, 0));
+        SV *pkg_name = newSVpv(class, 0);
         Perl_load_module(aTHX_ PERL_LOADMOD_NOIMPORT, pkg_name, Nullsv);
         stash = gv_stashpv(class, TRUE);
     }



Mime
View raw message