Return-Path: Delivered-To: apmail-httpd-apreq-cvs-archive@www.apache.org Received: (qmail 2653 invoked from network); 27 Jan 2005 21:47:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 27 Jan 2005 21:47:31 -0000 Received: (qmail 30799 invoked by uid 500); 27 Jan 2005 21:47:30 -0000 Delivered-To: apmail-httpd-apreq-cvs-archive@httpd.apache.org Received: (qmail 30767 invoked by uid 500); 27 Jan 2005 21:47:30 -0000 Mailing-List: contact apreq-cvs-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: apreq-dev@httpd.apache.org List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list apreq-cvs@httpd.apache.org Received: (qmail 30721 invoked by uid 99); 27 Jan 2005 21:47:30 -0000 X-ASF-Spam-Status: No, hits=-9.8 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from minotaur.apache.org (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.28) with SMTP; Thu, 27 Jan 2005 13:47:29 -0800 Received: (qmail 96773 invoked by uid 65534); 27 Jan 2005 21:40:07 -0000 Date: 27 Jan 2005 21:40:07 -0000 Message-ID: <20050127214007.96763.qmail@minotaur.apache.org> From: joes@apache.org To: apreq-cvs@httpd.apache.org Subject: svn commit: r128428 - /httpd/apreq/branches/multi-env-unstable/STATUS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Author: joes Date: Thu Jan 27 13:40:04 2005 New Revision: 128428 URL: http://svn.apache.org/viewcvs?view=rev&rev=128428 Log: Update my long-range goals for apreq_env_handle_t: replace bucket_alloc and pool functions with simple data strutures in apreq_parser_t (adding args to parser constructor) Modified: httpd/apreq/branches/multi-env-unstable/STATUS Modified: httpd/apreq/branches/multi-env-unstable/STATUS Url: http://svn.apache.org/viewcvs/httpd/apreq/branches/multi-env-unstable/STATUS?view=diff&rev=128428&p1=httpd/apreq/branches/multi-env-unstable/STATUS&r1=128427&p2=httpd/apreq/branches/multi-env-unstable/STATUS&r2=128428 ============================================================================== --- httpd/apreq/branches/multi-env-unstable/STATUS (original) +++ httpd/apreq/branches/multi-env-unstable/STATUS Thu Jan 27 13:40:04 2005 @@ -23,8 +23,6 @@ typedef struct apreq_env_module_t { const char *name; apr_uint32_t magic_number; - apr_pool_t *(*pool)(apreq_env_handle_t *); - apr_bucket_alloc_t *(*bucket_alloc)(apreq_env_handle_t *); apr_status_t (*jar)(apreq_env_handle_t *, const apr_table_t **); apr_status_t (*args)(apreq_env_handle_t *, const apr_table_t **); @@ -48,12 +46,18 @@ void (*log)(const char *,int,int,apr_status_t,apreq_env_handle_t *, const char *,va_list); + apr_pool_t *(*pool)(apreq_env_handle_t *); + apr_bucket_alloc_t *(*bucket_alloc)(apreq_env_handle_t *); + const char *(*temp_dir)(apreq_env_handle_t *, const char *); apr_off_t (*max_body)(apreq_env_handle_t *,apr_off_t); apr_ssize_t (*max_brigade)(apreq_env_handle_t *, apr_ssize_t); If possible the log calls inside libapreq2 should be replaced by error codes that either libapreq2 apps or modules can log (or not). + The pool and bucket_alloc functions should become simple pointers + in apreq_parser_t; env() doesn't need to provide them. + The rest are controls (temp_dir, max_body, max_brigade) that users will need to configure, and libapreq2 parsers will need to look at. However these APIs are missing status codes, for