httpd-apreq-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@apache.org
Subject svn commit: r109213 - /httpd/apreq/trunk/CHANGES /httpd/apreq/trunk/STATUS /httpd/apreq/trunk/src/apreq.c /httpd/apreq/trunk/src/apreq.h /httpd/apreq/trunk/src/apreq_version.h
Date Tue, 30 Nov 2004 17:33:55 GMT
Author: joes
Date: Tue Nov 30 09:33:54 2004
New Revision: 109213

URL: http://svn.apache.org/viewcvs?view=rev&rev=109213
Log:

Add flags to apreq_value_t, planning for future charset support.
This is an ABI change, starting with libapreq2.so.2.0.24.

Modified:
   httpd/apreq/trunk/CHANGES
   httpd/apreq/trunk/STATUS
   httpd/apreq/trunk/src/apreq.c
   httpd/apreq/trunk/src/apreq.h
   httpd/apreq/trunk/src/apreq_version.h

Modified: httpd/apreq/trunk/CHANGES
Url: http://svn.apache.org/viewcvs/httpd/apreq/trunk/CHANGES?view=diff&rev=109213&p1=httpd/apreq/trunk/CHANGES&r1=109212&p2=httpd/apreq/trunk/CHANGES&r2=109213
==============================================================================
--- httpd/apreq/trunk/CHANGES	(original)
+++ httpd/apreq/trunk/CHANGES	Tue Nov 30 09:33:54 2004
@@ -4,6 +4,9 @@
 
 @section v2_05 Changes with libapreq2-2.05
 
+- C API [joes]
+  Add "flags" attribute to apreq_value_t, planning for charset support.
+  This is an ABI change, starting with libapreq2.so.2.0.24.
 
 - C API [joes]
   Add apreq_env_bucket_alloc() to get an allocator directly from the

Modified: httpd/apreq/trunk/STATUS
Url: http://svn.apache.org/viewcvs/httpd/apreq/trunk/STATUS?view=diff&rev=109213&p1=httpd/apreq/trunk/STATUS&r1=109212&p2=httpd/apreq/trunk/STATUS&r2=109213
==============================================================================
--- httpd/apreq/trunk/STATUS	(original)
+++ httpd/apreq/trunk/STATUS	Tue Nov 30 09:33:54 2004
@@ -14,18 +14,6 @@
 
 RELEASE SHOWSTOPPERS:
 
-    - We need to add a "flags" field to apreq_value_t, mainly
-      for charset support.  Long discussion starts here
-            http://article.gmane.org/gmane.comp.apache.apreq/2371
-
-      This is an ABI change, so it must be carried out prior
-      to the 2.05 release.
-
-      joes comments: We don't need to actually do anything with the flags
-      prior to 2.05.  It just needs to be present in the struct; that
-      way we can add charset support gradually, but without breaking 
-      our ABI.
-
 
 
 CURRENT VOTES:
@@ -45,6 +33,10 @@
 
 
 TODO:
+
+    - We need to add some basic charset support.  Long discussion 
+      starts here:
+              http://article.gmane.org/gmane.comp.apache.apreq/2371
 
     - There are too many calls to apreq_env_pool()- lots of these
       can be eliminated by caching the pool in the parser's context.

Modified: httpd/apreq/trunk/src/apreq.c
Url: http://svn.apache.org/viewcvs/httpd/apreq/trunk/src/apreq.c?view=diff&rev=109213&p1=httpd/apreq/trunk/src/apreq.c&r1=109212&p2=httpd/apreq/trunk/src/apreq.c&r2=109213
==============================================================================
--- httpd/apreq/trunk/src/apreq.c	(original)
+++ httpd/apreq/trunk/src/apreq.c	Tue Nov 30 09:33:54 2004
@@ -41,6 +41,7 @@
     memcpy((char *)v->name, name, nlen);
     ((char *)v->name)[nlen] = 0;
 
+    v->flags = 0;
     return v;
 }
 

Modified: httpd/apreq/trunk/src/apreq.h
Url: http://svn.apache.org/viewcvs/httpd/apreq/trunk/src/apreq.h?view=diff&rev=109213&p1=httpd/apreq/trunk/src/apreq.h&r1=109212&p2=httpd/apreq/trunk/src/apreq.h&r2=109213
==============================================================================
--- httpd/apreq/trunk/src/apreq.h	(original)
+++ httpd/apreq/trunk/src/apreq.h	Tue Nov 30 09:33:54 2004
@@ -66,6 +66,7 @@
 typedef struct apreq_value_t {
     const char    *name;    /**< value's name */
     apr_size_t     size;    /**< Size of data.*/
+    unsigned char  flags;   /**< reserved (for future charset support) */
     char           data[1]; /**< Actual data bytes.*/
 } apreq_value_t;
 

Modified: httpd/apreq/trunk/src/apreq_version.h
Url: http://svn.apache.org/viewcvs/httpd/apreq/trunk/src/apreq_version.h?view=diff&rev=109213&p1=httpd/apreq/trunk/src/apreq_version.h&r1=109212&p2=httpd/apreq/trunk/src/apreq_version.h&r2=109213
==============================================================================
--- httpd/apreq/trunk/src/apreq_version.h	(original)
+++ httpd/apreq/trunk/src/apreq_version.h	Tue Nov 30 09:33:54 2004
@@ -61,7 +61,7 @@
 #define APREQ_MINOR_VERSION       0
 
 /** patch level */
-#define APREQ_PATCH_VERSION      23
+#define APREQ_PATCH_VERSION      24
 
 /** 
  *  This symbol is defined for internal, "development" copies of libapreq.

Mime
View raw message