httpd-apreq-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@apache.org
Subject cvs commit: httpd-apreq-2/glue/perl/xsbuilder/Apache/Upload Apache__Upload.h
Date Sun, 11 Jul 2004 20:28:47 GMT
joes        2004/07/11 13:28:47

  Modified:    glue/perl/xsbuilder/Apache/Upload Apache__Upload.h
  Log:
  Add some type safety by tagging magic keys with the object which created them.  That should
prevent segfaults that could occur; for example if magic keys from a cookie table are passed
to ->upload (the returned objects are of different types, so the v-string magic in the
cookie key needs to be ignored).
  
  Revision  Changes    Path
  1.24      +1 -5      httpd-apreq-2/glue/perl/xsbuilder/Apache/Upload/Apache__Upload.h
  
  Index: Apache__Upload.h
  ===================================================================
  RCS file: /home/cvs/httpd-apreq-2/glue/perl/xsbuilder/Apache/Upload/Apache__Upload.h,v
  retrieving revision 1.23
  retrieving revision 1.24
  diff -u -r1.23 -r1.24
  --- Apache__Upload.h	11 Jul 2004 20:26:43 -0000	1.23
  +++ Apache__Upload.h	11 Jul 2004 20:28:47 -0000	1.24
  @@ -93,11 +93,7 @@
           return 1;
   
       sv = newSVpv(key,0);
  -
  -    sv_magic(sv, d->parent, PERL_MAGIC_vstring, Nullch, -1);
  -    SvMAGIC(sv)->mg_ptr = (char *)val;
  -    SvRMAGICAL_on(sv);
  -
  +    APREQ_XS_TABLE_ADD_KEY_MAGIC(apreq_env_pool(d->env),sv,d->parent,val);
       XPUSHs(sv_2mortal(sv));
       PUTBACK;
       return 1;
  
  
  

Mime
View raw message