htrace-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin P. McCabe" <cmcc...@apache.org>
Subject Re: HTrace 4.1 release candidate 1
Date Fri, 05 Feb 2016 01:56:01 GMT
On Thu, Feb 4, 2016 at 10:45 AM, Elliott Clark <eclark@apache.org> wrote:
> I don't think that the CSS is a big deal, since it's thirdparty and covered
> by LICENSE file.
> The java file is generated, and the protofile that generates it is fine.
>
>
> +1
> mvn apache-rat:check passed cleanly.
>
> sig is good
> tar looks good.
>
>
> Things I noticed:
> It's weird to have jars published in maven for modules with no java in them

Yeah, I agree, it's a little annoying.  It looks like they just
contain the pom.xml and pom.properties files.

cmccabe@mirabilis:~/htrace2> jar tvf
./htrace-c/target/htrace-c-4.1.0-incubating-SNAPSHOT.jar
     0 Thu Jan 21 11:14:44 PST 2016 META-INF/
   450 Thu Jan 21 11:14:42 PST 2016 META-INF/MANIFEST.MF
   258 Thu Jan 21 11:14:34 PST 2016 META-INF/DEPENDENCIES
 11358 Thu Jan 21 11:14:34 PST 2016 META-INF/LICENSE
   160 Thu Jan 21 11:14:34 PST 2016 META-INF/NOTICE
     0 Thu Jan 21 11:14:44 PST 2016 META-INF/maven/
     0 Thu Jan 21 11:14:44 PST 2016 META-INF/maven/org.apache.htrace/
     0 Thu Jan 21 11:14:44 PST 2016 META-INF/maven/org.apache.htrace/htrace-c/
  4025 Thu Jan 21 11:13:22 PST 2016
META-INF/maven/org.apache.htrace/htrace-c/pom.xml
   130 Thu Jan 21 11:14:44 PST 2016
META-INF/maven/org.apache.htrace/htrace-c/pom.properties

It's not doing any harm, but I would welcome a patch to fix this (if
it's possible in Maven... ya never know).  It seems like that could be
done in a follow-on release, doesn't have to be in 4.1.

I filed HTRACE-343 to continue this discussion.

> Do we need to sink the release for the year ?
> Building instructions doesn't seem too bad since it's been there for a
> while.

Yeah, by itself, HTRACE-342 is probably not worth spinning a new
release over.  The patch is up, though so give it a look.

best,
Colin

>
> On Tue, Feb 2, 2016 at 7:00 PM, Colin P. McCabe <cmccabe@apache.org> wrote:
>
>> Thanks for looking at this, Lewis.
>>
>> On Tue, Feb 2, 2016 at 6:25 PM, Lewis John Mcgibbney
>> <lewis.mcgibbney@gmail.com> wrote:
>> > Hi Colin,
>> >
>> > Signatures Good
>> > Aggregated results of running DRAT over the release candidate
>> >
>> > Notes Binaries Archives Standards Apache Generated Unknown
>> > 0 0 0 142 118 0 15
>> > Unapproved licenses include
>> >
>> >
>> >
>> /usr/local/drat/deploy/data/jobs/rat/1454465689433/input/bootstrap-theme.css
>> >
>> >
>> /usr/local/drat/deploy/data/jobs/rat/1454465689433/input/bootstrap-theme.min.css
>> >   /usr/local/drat/deploy/data/jobs/rat/1454465689433/input/bootstrap.css
>> >
>>  /usr/local/drat/deploy/data/jobs/rat/1454465689433/input/bootstrap.min.css
>> >
>>  /usr/local/drat/deploy/data/jobs/rat/1454465688911/input/backbone-1.1.2.js
>> >   /usr/local/drat/deploy/data/jobs/rat/1454465688911/input/bootstrap.js
>> >
>>  /usr/local/drat/deploy/data/jobs/rat/1454465688911/input/bootstrap.min.js
>> >   /usr/local/drat/deploy/data/jobs/rat/1454465688911/input/d3.min.js
>> >
>>  /usr/local/drat/deploy/data/jobs/rat/1454465688911/input/jquery-2.1.4.js
>> >
>>  /usr/local/drat/deploy/data/jobs/rat/1454465688911/input/moment-2.10.3.js
>> >   /usr/local/drat/deploy/data/jobs/rat/1454465688911/input/npm.js
>> >
>> >
>> /usr/local/drat/deploy/data/jobs/rat/1454465688911/input/underscore-1.7.0.js
>> >
>>  /usr/local/drat/deploy/data/jobs/rat/1454465688785/input/SpanProtos.java
>> >
>> >
>> /usr/local/drat/deploy/data/jobs/rat/1454465689194/input/dependency-reduced-pom.xml
>> >
>> >
>> /usr/local/drat/deploy/data/jobs/rat/1454465689194/input/dependency-reduced-pom.xml_02022016_1814
>> >
>> > I understand that the .css and .js files above are covered in LICENSE at
>> > the bottom however we need to address the following files
>> >
>> >
>>  /usr/local/drat/deploy/data/jobs/rat/1454465688785/input/SpanProtos.java
>> >
>> >
>> /usr/local/drat/deploy/data/jobs/rat/1454465689194/input/dependency-reduced-pom.xml
>> >
>> >
>> /usr/local/drat/deploy/data/jobs/rat/1454465689194/input/dependency-reduced-pom.xml_02022016_1814
>>
>> Hmm.  I think we talked about SpanProtos.java,
>> dependency-reduced-pom.xml, etc. during the previous release and
>> concluded that they are generated files, and hence exempt from the
>> license requirement according to
>>
>> http://incubator.apache.org/guides/releasemanagement.html#notes-license-headers
>>
>> >
>> > NOTICE includes
>> > Copyright 2015 The Apache Software Foundation
>> > This should be
>> > Copyright 2016 The Apache Software Foundation
>> >
>>
>> OK
>>
>> > There seems to be a bit on confusion between instructions for Building
>> the
>> > code. We have the note in README.md and then a separate note within
>> > BUILDING.txt. We should probably resolve this and include them both in
>> > README.md
>> >
>>
>> OK, I created HTRACE-342 to fix this.
>>
>> > Build and tests pass fine.
>> >
>> > Typically the absence of the license header in the above files would be a
>> > -1 from me. I will wait to see how others review the candidate before
>> > VOTE'ing.
>> > Good job putting this together.
>>
>> Thanks
>>
>> best,
>> Colin
>>
>> >
>> >
>> > On Tue, Feb 2, 2016 at 4:51 PM, <
>> dev-digest-help@htrace.incubator.apache.org
>> >> wrote:
>> >
>> >>
>> >> Hi all,
>> >>
>> >> I've posted the first release candidate for HTrace 4.1 here:
>> >>
>> >> http://people.apache.org/~cmccabe/htrace/releases/4.1.0/rc1/
>> >>
>> >> The jars have been staged here:
>> >>
>> >> https://repository.apache.org/content/repositories/orgapachehtrace-1021
>> >>
>> >> HTrace 4.1 brings a lot of robustness improvements.  There were major
>> >> improvements to htraced and the web UI, as well as new metrics added.
>> >> There were numerous build fixups, and we added Docker support, to
>> >> ensure a repeatable build.
>> >>
>> >> Check it out.  The vote will run for 5 days.
>> >>
>> >> cheers,
>> >> Colin
>> >>
>> >> Release Notes - HTrace - Version 4.1
>> >> ** Bug
>> >>     * [HTRACE-114] - Fix compilation error of htrace-hbase against
>> >> hbase-1.0.0
>> >>     * [HTRACE-238] - Change maven compiler source level to 1.7 to
>> >> match targetJdk
>> >>     * [HTRACE-243] - Remove duplicate maven-assembly-plugin
>> >> configuration section in htrace-htraced/pom.xml
>> >>     * [HTRACE-245] - NOTICE.txt: change "developed by The Apache
>> >> Software...” to "developed at The Apache Software...”
>> >>     * [HTRACE-246] - HTrace WebApp not properly defined and therefore
>> >> not packaged into .war
>> >>     * [HTRACE-248] - HTraced should gracefully shutdown if stopped
>> >>     * [HTRACE-249] - Script and doc on how to publish website
>> >>     * [HTRACE-251] - Fix "mvn clean" target
>> >>     * [HTRACE-253] - Tracer loadSamplers and loadSpanReceivers logs
>> >> are too chatty
>> >>     * [HTRACE-256] - Change the artifactId for htrace-core in branch
>> >> 4.0 to be htrace-core4
>> >>     * [HTRACE-257] - htrace-htraced: add web symlink rather than
>> >> generating programmatically
>> >>     * [HTRACE-262] - Temporarily suppress doclint for Java 8 to
>> >> prevent build failure
>> >>     * [HTRACE-266] - Make the CLIENT_REST_MAX_SPANS_AT_A_TIME_KEY
>> >> config key more consistent with other configs
>> >>     * [HTRACE-267] - Move owl logo licensing information from NOTICE to
>> >> LICENSE
>> >>     * [HTRACE-268] - Remove Units and go-codec from LICENSE since they
>> >> are not contained in the source release
>> >>     * [HTRACE-272] - TracerPool must not load multiple inscance of
>> >> same receiver class when a simple classname is given
>> >>     * [HTRACE-279] - Fix issues where the HTracedSpanReceiver was
>> >> using the wrong JSON serialization for spans and add validation to
>> >> htraced REST ingest path
>> >>     * [HTRACE-280] - htraced: add metrics about total spans added and
>> >> dropped per address
>> >>     * [HTRACE-281] - htraced: add example/htraced-conf.xml
>> >>     * [HTRACE-282] - htraced: reap spans which are older than a
>> >> configurable interval
>> >>     * [HTRACE-283] - Heartbeater should wait for goroutine to finish on
>> >> close
>> >>     * [HTRACE-284] - htrace-htraced, htrace-flume: do not treat the
>> >> shaded version of commons-logging as provided
>> >>     * [HTRACE-285] - htraced tool: fix query parsing and add query_test
>> >>     * [HTRACE-289] - Fix TraceEnabled, etc. logger methods for
>> >> conditional logging
>> >>     * [HTRACE-294] - htraced: fix some metrics issues
>> >>     * [HTRACE-297] - htraced: avoid serializing spans to json unless
>> >> TRACE logging is enabled
>> >>     * [HTRACE-300] - Reaper should be initialized before shards are
>> >> activated
>> >>     * [HTRACE-301] - htraced: fix unit tests that aren't waiting for
>> >> spans to be written, use semaphore for WrittenSpans
>> >>     * [HTRACE-302] - htraced: Add admissions control to HRPC to limit
>> >> the number of incoming messages
>> >>     * [HTRACE-304] - htraced: fix bug with GREATER_THAN queries
>> >>     * [HTRACE-307] - htraced: queries sometimes return no results even
>> >> when many results exist due to confusion in iterator usage
>> >>     * [HTRACE-311] - htraced: Fix logging to stdout via -Dlog.path=
>> >>     * [HTRACE-316] - htrace-web: span.js issue: span ID string length
>> >> is 32, not 36
>> >>     * [HTRACE-317] - Fix the documentation for adding tracing to an
>> >> application to reflect HTrace 4.x API changes
>> >>     * [HTRACE-328] - htraced continues scanning in some cases even
>> >> when no more results are possible
>> >>
>> >> ** Improvement
>> >>     * [HTRACE-129] - htraced: add /server/stats REST endpoint
>> >>     * [HTRACE-156] - HTrace GUI: add about view
>> >>     * [HTRACE-181] - gui: Split "about" screen
>> >>     * [HTRACE-237] - Optimize htraced span receiver
>> >>     * [HTRACE-239] - Add htrace/impl/TestZipkinSpanReceiver.java
>> >>     * [HTRACE-260] - htrace-zipkin should not set the obsolete
>> >> duration field in thrift
>> >>     * [HTRACE-271] - Add log4j.properties to all submodule tests
>> >>     * [HTRACE-276] - Shade classes into org.apache.htrace.shaded
>> >> rather than org.apache.htrace
>> >>     * [HTRACE-286] - htraced: improvements to logging, daemon startup,
>> >> and configuration
>> >>     * [HTRACE-290] - htraced: Fix per-faculty log level settings and
>> >> add unit tests for conditional logging
>> >>     * [HTRACE-291] - rename bin/htrace to bin/htracedTool
>> >>     * [HTRACE-292] - "htracedTool version" should display the git
>> >> hash, and -Dgit.version option should be available for build
>> >>     * [HTRACE-295] - htraced: setting span.expiry.ms to 0 should
>> >> disable span expiry
>> >>     * [HTRACE-296] - htraced tests: make sure local settings for
>> >> HTRACED_WEB_DIR and HTRACE_CONF_DIR don't affect unit tests
>> >>     * [HTRACE-298] - htraced: improve datastore serialization and
>> metrics
>> >>     * [HTRACE-303] - Add client-side htraceDropped log file to track
>> >> dropped spans
>> >>     * [HTRACE-305] - htrace-web: Use greater-than-or-equal rather than
>> >> greater-than in more places
>> >>     * [HTRACE-306] - htraced: logs should use UTC
>> >>     * [HTRACE-308] - Deserialize WriteSpans requests incrementally
>> >> rather than all at once to optimize GC
>> >>     * [HTRACE-310] - htracedTool: when there is an error response,
>> >> print the body of the response
>> >>     * [HTRACE-312] - htraced: if GOMAXPROCS is left at 1, set it to
>> >> the number of CPUs
>> >>     * [HTRACE-313] - htraced span receiver clientDropped file should
>> >> include timestamps
>> >>     * [HTRACE-314] - htraced: make datastore loading safer
>> >>     * [HTRACE-327] - HTRACE-327: improve htraced command-line parsing
>> >> and add version command
>> >>     * [HTRACE-334] - htrace-web: Make limit of search and children API
>> >> configurable
>> >>     * [HTRACE-335] - htrace-web: Adjust size of span widget
>> >>     * [HTRACE-339] - Major type in htrace-flume README
>> >>
>> >> ** New Feature
>> >>     * [HTRACE-235] - htrace-zipkin - add Kafka transport support
>> >>     * [HTRACE-277] - htraced: Add /server/conf endpoint to get server
>> >> configuration
>> >>     * [HTRACE-278] - htraced: dump thread stacks and GC statistics
>> >> when SIGQUIT is sent
>> >>     * [HTRACE-288] - htraced: Add a user interface to view server
>> >> version, metrics, and configuration
>> >>     * [HTRACE-293] - htrace-web: control-click should fully expand trace
>> >> trees
>> >>     * [HTRACE-299] - htraced: add /server/debugInfo REST endpoint to
>> >> get stack traces and GC stats
>> >>     * [HTRACE-309] - htraced: improve leveldb configuration
>> >>     * [HTRACE-323] - htrace-web: change the cursor to a spinner while
>> >> a search is in progress
>> >>     * [HTRACE-332] - htraced: optionally enable leveldb LRU cache
>> >>
>> >> ** Task
>> >>     * [HTRACE-241] - Docker image for HTrace
>> >>     * [HTRACE-315] - htraced: change default web port from 9095 to 9096
>> >>     * [HTRACE-319] - mark versions 4.0 and 4.0.1 as released
>> >>     * [HTRACE-331] - create git tags for 4.0 and 4.0.1 releases
>> >>
>> >> ** Wish
>> >>     * [HTRACE-269] - HTraceConfiguration support to get the map of
>> >> configurations
>> >>
>> >>
>> >>
>> >
>> >
>> > --
>> > *Lewis*
>>

Mime
View raw message