htrace-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stack <st...@duboce.net>
Subject Re: [VOTE] htrace-3.1.0, fourth release candidate
Date Wed, 31 Dec 2014 20:33:58 GMT
Ok lads.  Thanks. New RC coming up.
St.Ack

On Wed, Dec 31, 2014 at 11:52 AM, Elliott Clark <eclark@apache.org> wrote:

> I think that along with htrace-39 is enough to sink this release.
>
> On Wed, Dec 31, 2014 at 11:15 AM, Long Zhou <longzhouwk@gmail.com> wrote:
>
> > Hi Stack,
> >
> >     Trace.java calls random.nextLong() to generate SpanId, and its value
> > will be negative 50% of the time. The bug can be easily reproduced with
> the
> > two test cases I have added in the patch.
> >     Currently MilliSpanDeserializer is not consumed within htrace
> project.
> > However if anyone (internal or external) needs to use the deserializer,
> > this would be a blocking issue.
> >
> > Thanks,
> > Long Zhou
> >
> > On Wed, Dec 31, 2014 at 10:56 AM, Stack <stack@duboce.net> wrote:
> >
> > > On Wed, Dec 31, 2014 at 10:48 AM, Long Zhou <longzhouwk@gmail.com>
> > wrote:
> > >
> > > > Can we include fix for HTRACE-40 in this release?
> > > >
> > > > HTRACE-40 <https://issues.apache.org/jira/browse/HTRACE-40>:
> > > > MilliSpanDeserializer throws NumberFormatException when Span has
> > negative
> > > > Long value
> > > >
> > >
> > > Does a negative number make any sense? You think this a critical issue?
> > > St.Ack
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message