Mailing-List: contact dev-help@horn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@horn.incubator.apache.org
MIME-Version: 1.0
In-Reply-To: <CABaiRmfXVa4cPf+4xsqwV34H1AJV-v7sPG0tVTHiX7-zsGA4+A@mail.gmail.com>
References: <01bd01d1ff32$764c3ad0$62e4b070$@samsung.com> <CACHLYnnZFA_e+v-50VHscAY8wgdp3hgA_a8yqEKbEq2W8JdE_g@mail.gmail.com>
 <CABaiRmfXVa4cPf+4xsqwV34H1AJV-v7sPG0tVTHiX7-zsGA4+A@mail.gmail.com>
From: "Edward J. Yoon" <edwardyoon@apache.org>
Date: Sat, 3 Sep 2016 21:05:12 +0900
Message-ID: <CAGQgZQTpYPV9BjZaCWE-OO=Bb7x+2D_GGhtUeFsX54vZrNPNOw@mail.gmail.com>
Subject: Re: Use vector instead of Iterable in neuron API
To: Apache Horn Dev <dev@horn.incubator.apache.org>
Content-Type: text/plain; charset=UTF-8
archived-at: Sat, 03 Sep 2016 12:05:20 -0000

Interesting. Can you share your test code?

On Sat, Sep 3, 2016 at 2:17 AM, Baran Topal <barantopal@barantopal.com> wrote:
> Hi Edward and team;
>
> I had a brief test by refactoring Iterable to Vector and on
> TestNeuron.java, I can see some improved times. I didn't check for
> other existing test methods but it seems the execution times are
> improving for both forwarding and backwarding.
>
> These values are via System.currentTimeMillis().
>
> E.g.
>
>
> Execution time for the forward function is: 5722329
> Execution time for the backward function is: 31825
>
> Execution time for the refactored forward function is: 72330
> Execution time for the refactored backward function is: 4665
>
> Br.
>
> 2016-09-02 2:14 GMT+02:00 Yeonhee Lee <ssallys0130@gmail.com>:
>> Hi Edward,
>>
>> If we don't have that kind of method in the neuron, I guess it's
>> appropriate to put the method to the neuron.
>> That can be one of the distinct features of Horn.
>>
>> Regards,
>> Yeonhee
>>
>>
>> 2016-08-26 9:40 GMT+09:00 Edward J. Yoon <edward.yoon@samsung.com>:
>>
>>> Hi forks,
>>>
>>> Our current neuron API is designed like:
>>> https://github.com/apache/incubator-horn/blob/master/
>>> README.md#programming-m
>>> odel
>>>
>>> In forward() method, each neuron receives the pairs of the inputs x1, x2,
>>> ... xn from other neurons and weights w1, w2, ... wn like below:
>>>
>>>   public void forward(Iterable<M> messages) throws IOException;
>>>
>>> Instead of this, I suggest that we use just vector like below:
>>>
>>>   /**
>>>    * @param input vector from other neurons
>>>    * /
>>>   public void forward(Vector input) throws IOException;
>>>
>>> And, the neuron provides a getWeightVector() method that returns weight
>>> vector associated with itself. I think this is more make sense than current
>>> version, and more easy to use GPU in the future.
>>>
>>> What do you think?
>>>
>>> Thanks.
>>>
>>> --
>>> Best Regards, Edward J. Yoon
>>>
>>>
>>>
>>>
>>>


-- 
Best Regards, Edward J. Yoon