Mailing-List: contact dev-help@horn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@horn.incubator.apache.org
Date: Fri, 13 Nov 2015 16:14:10 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@horn.incubator.apache.org
Message-ID: <JIRA.12912675.1447375564000.63029.1447431250979@Atlassian.JIRA>
In-Reply-To: <JIRA.12912675.1447375564000@Atlassian.JIRA>
References: <JIRA.12912675.1447375564000@Atlassian.JIRA>
 <JIRA.12912675.1447375564778@arcas>
Subject: [jira] [Commented] (HORN-9) Add activations package and ReLU
 function
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HORN-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004190#comment-15004190 ] 

ASF GitHub Bot commented on HORN-9:
-----------------------------------

Github user ZJaffee commented on a diff in the pull request:

    https://github.com/apache/incubator-horn/pull/4#discussion_r44799975
  
    --- Diff: src/main/java/org/apache/horn/activations/Tanh.java ---
    @@ -0,0 +1,38 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.horn.activations;
    +
    +import org.apache.hama.commons.math.DoubleFunction;
    +
    +/**
    + * Tanh function.
    + * 
    + */
    +public class Tanh extends DoubleFunction {
    +
    +  @Override
    +  public double apply(double value) {
    +    return Math.tanh(value);
    +  }
    +
    +  @Override
    +  public double applyDerivative(double value) {
    +    return 1 - value * value;
    --- End diff --
    
    Maybe I am misunderstanding, but isn't the derivative of tanh(x) equal to 1-tanh^2(x) rather than 1-x^2


> Add activations package and ReLU function
> -----------------------------------------
>
>                 Key: HORN-9
>                 URL: https://issues.apache.org/jira/browse/HORN-9
>             Project: Apache Horn
>          Issue Type: New Feature
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>
> Adding activation function implementations.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)