Return-Path: Delivered-To: apmail-jakarta-hivemind-cvs-archive@www.apache.org Received: (qmail 59730 invoked from network); 3 Aug 2005 09:35:27 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 3 Aug 2005 09:35:27 -0000 Received: (qmail 76015 invoked by uid 500); 3 Aug 2005 09:35:27 -0000 Delivered-To: apmail-jakarta-hivemind-cvs-archive@jakarta.apache.org Received: (qmail 75996 invoked by uid 500); 3 Aug 2005 09:35:26 -0000 Mailing-List: contact hivemind-cvs-help@jakarta.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: hivemind-dev@jakarta.apache.org List-Id: Delivered-To: mailing list hivemind-cvs@jakarta.apache.org Received: (qmail 75983 invoked by uid 99); 3 Aug 2005 09:35:26 -0000 X-ASF-Spam-Status: No, hits=-9.8 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [209.237.227.194] (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 03 Aug 2005 02:35:14 -0700 Received: (qmail 59417 invoked by uid 65534); 3 Aug 2005 09:35:12 -0000 Message-ID: <20050803093512.59414.qmail@minotaur.apache.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r227188 - in /jakarta/hivemind/trunk: framework/src/java/org/apache/hivemind/service/ClassFabUtils.java framework/src/test/org/apache/hivemind/service/impl/TestClassFabUtils.java status.xml Date: Wed, 03 Aug 2005 09:35:11 -0000 To: hivemind-cvs@jakarta.apache.org From: knut@apache.org X-Mailer: svnmailer-1.0.3 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: knut Date: Wed Aug 3 02:33:55 2005 New Revision: 227188 URL: http://svn.apache.org/viewcvs?rev=227188&view=rev Log: ClassFabUtils.addNoOpMethod() now creates a return statement with the return values 0L, 0.0d, 0.0f for the return types long, double, and float respectively. Fixes HIVEMIND-144. Modified: jakarta/hivemind/trunk/framework/src/java/org/apache/hivemind/service/ClassFabUtils.java jakarta/hivemind/trunk/framework/src/test/org/apache/hivemind/service/impl/TestClassFabUtils.java jakarta/hivemind/trunk/status.xml Modified: jakarta/hivemind/trunk/framework/src/java/org/apache/hivemind/service/ClassFabUtils.java URL: http://svn.apache.org/viewcvs/jakarta/hivemind/trunk/framework/src/java/org/apache/hivemind/service/ClassFabUtils.java?rev=227188&r1=227187&r2=227188&view=diff ============================================================================== --- jakarta/hivemind/trunk/framework/src/java/org/apache/hivemind/service/ClassFabUtils.java (original) +++ jakarta/hivemind/trunk/framework/src/java/org/apache/hivemind/service/ClassFabUtils.java Wed Aug 3 02:33:55 2005 @@ -146,6 +146,12 @@ { if (returnType == boolean.class) body.append(" false"); + else if (returnType == long.class) + body.append(" 0L"); + else if (returnType == float.class) + body.append(" 0.0f"); + else if (returnType == double.class) + body.append(" 0.0d"); else body.append(" 0"); } Modified: jakarta/hivemind/trunk/framework/src/test/org/apache/hivemind/service/impl/TestClassFabUtils.java URL: http://svn.apache.org/viewcvs/jakarta/hivemind/trunk/framework/src/test/org/apache/hivemind/service/impl/TestClassFabUtils.java?rev=227188&r1=227187&r2=227188&view=diff ============================================================================== --- jakarta/hivemind/trunk/framework/src/test/org/apache/hivemind/service/impl/TestClassFabUtils.java (original) +++ jakarta/hivemind/trunk/framework/src/test/org/apache/hivemind/service/impl/TestClassFabUtils.java Wed Aug 3 02:33:55 2005 @@ -51,8 +51,13 @@ { tryAddNoOpMethod(void.class, "{ }"); tryAddNoOpMethod(String.class, "{ return null; }"); - tryAddNoOpMethod(int.class, "{ return 0; }"); tryAddNoOpMethod(boolean.class, "{ return false; }"); + tryAddNoOpMethod(char.class, "{ return 0; }"); + tryAddNoOpMethod(short.class, "{ return 0; }"); + tryAddNoOpMethod(int.class, "{ return 0; }"); + tryAddNoOpMethod(long.class, "{ return 0L; }"); + tryAddNoOpMethod(double.class, "{ return 0.0d; }"); + tryAddNoOpMethod(float.class, "{ return 0.0f; }"); } /** @since 1.1 */ @@ -75,7 +80,6 @@ } /** @since 1.1 */ - public void testGenerateClassName() throws Exception { String name = ClassFabUtils.generateClassName(Runnable.class); Modified: jakarta/hivemind/trunk/status.xml URL: http://svn.apache.org/viewcvs/jakarta/hivemind/trunk/status.xml?rev=227188&r1=227187&r2=227188&view=diff ============================================================================== --- jakarta/hivemind/trunk/status.xml (original) +++ jakarta/hivemind/trunk/status.xml Wed Aug 3 02:33:55 2005 @@ -33,6 +33,7 @@ Change dist targets to use SSH passphrase for authentication. Allow for null values in <invoke-parent> rule. + PlaceholderFactory generates incorrect return statement for some primitive return types. IBM JDK 1.4.1 and java.net.URL.openStream causes NPE" --------------------------------------------------------------------- To unsubscribe, e-mail: hivemind-cvs-unsubscribe@jakarta.apache.org For additional commands, e-mail: hivemind-cvs-help@jakarta.apache.org