hivemall-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From myui <...@git.apache.org>
Subject [GitHub] incubator-hivemall pull request #167: [HIVEMALL-220] Implement Cofactor
Date Fri, 19 Oct 2018 09:01:23 GMT
Github user myui commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/167#discussion_r226578153
  
    --- Diff: core/src/main/java/hivemall/fm/Feature.java ---
    @@ -383,4 +383,10 @@ public static void l2normalize(@Nonnull final Feature[] features)
{
             }
         }
     
    +    @Override
    --- End diff --
    
    Why this `equals` method is required? Assume this is not used.


---

Mime
View raw message