hivemall-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From myui <...@git.apache.org>
Subject [GitHub] incubator-hivemall pull request #154: [HIVEMALL-210][BUGFIX] Fix a bug in ld...
Date Sat, 04 Aug 2018 18:04:45 GMT
GitHub user myui opened a pull request:

    https://github.com/apache/incubator-hivemall/pull/154

    [HIVEMALL-210][BUGFIX] Fix a bug in lda_predict/plsa_predict

    ## What changes were proposed in this pull request?
    
    Fixed a bug in lda_predict/plsa_predict that duplicated term probability is [unexpectedly
replaced](https://github.com/apache/incubator-hivemall/blame/a8a97d6e873d5a8a30b06f92ddc14d1ec95c2738/core/src/main/java/hivemall/topicmodel/LDAPredictUDAF.java#L396)
    
    ## What type of PR is it?
    
    Bug Fix
    
    ## What is the Jira issue?
    
    https://issues.apache.org/jira/browse/HIVEMALL-210
    
    ## How was this patch tested?
    
    unit tests and manual tests
    
    ## Checklist
    
    - [x] Did you apply source code formatter, i.e., `./bin/format_code.sh`, for your commit?
    - [ ] Did you run system tests on Hive (or Spark)?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/myui/incubator-hivemall HIVEMALL-210

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hivemall/pull/154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #154
    
----
commit 4e38897afc7af92e82635198359103d79b25dc82
Author: Makoto Yui <myui@...>
Date:   2018-08-04T17:55:59Z

    Added sortable KeyValue structs

commit 2ab5bf5cf3862f20e7c5aa096cf8d7c65cde9b50
Author: Makoto Yui <myui@...>
Date:   2018-08-04T17:56:37Z

    Fixed a bug in lda_predict and plsa_predict

----


---

Mime
View raw message