hivemall-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From myui <...@git.apache.org>
Subject [GitHub] incubator-hivemall pull request #149: [HIVEMALL-201] Evaluate, fix and docum...
Date Fri, 06 Jul 2018 10:20:29 GMT
Github user myui commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/149#discussion_r200611442
  
    --- Diff: core/src/main/java/hivemall/fm/FieldAwareFactorizationMachineModel.java ---
    @@ -51,11 +50,6 @@
         public FieldAwareFactorizationMachineModel(@Nonnull FFMHyperParameters params) {
             super(params);
             this._params = params;
    -        if (params.useAdaGrad) {
    -            this._eta0 = 1.0f;
    --- End diff --
    
    better to use large default eta0 for adagrad.


---

Mime
View raw message