hivemall-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From takuti <...@git.apache.org>
Subject [GitHub] incubator-hivemall pull request #149: [WIP][HIVEMALL-201] Evaluate, fix and ...
Date Thu, 17 May 2018 05:41:30 GMT
GitHub user takuti opened a pull request:

    https://github.com/apache/incubator-hivemall/pull/149

    [WIP][HIVEMALL-201] Evaluate, fix and document FFM

    ## What changes were proposed in this pull request?
    
    - Evaluate FFM so Hivemall replicates comparable accuracy to [LIBFFM](https://github.com/guestwalk/libffm).
    - Fix its implementation if needed
    - Document how to use FFM
    
    ## What type of PR is it?
    
    Bug Fix, Improvement, Documentation
    
    ## What is the Jira issue?
    
    https://issues.apache.org/jira/browse/HIVEMALL-201
    
    ## How was this patch tested?
    
    Unit tests and manual tests
    
    ## How to use this feature?
    
    (To be documented)
    
    ## Checklist
    
    - [x] Did you apply source code formatter, i.e., `mvn formatter:format`, for your commit?
    - [ ] Did you run system tests on Hive (or Spark)?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/takuti/incubator-hivemall HIVEMALL-201

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hivemall/pull/149.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #149
    
----
commit c67744cbe60711a9cb9da5c55a4157f9d107dbf3
Author: Takuya Kitazawa <k.takuti@...>
Date:   2018-05-16T08:39:32Z

    Use pre-defined constants in option description

commit d77f0161220327a4e2ef12f368f329dc56c1c941
Author: Takuya Kitazawa <k.takuti@...>
Date:   2018-05-16T08:40:48Z

    Fix mismatch between opts.addOption and cl.getOptionValue

commit c8e374b8bfb87a0ed420604aca2340c974770f50
Author: Takuya Kitazawa <k.takuti@...>
Date:   2018-05-16T08:41:34Z

    Support FFM feature format in `l1_normalize` and `l2_normalize`

----


---

Mime
View raw message