hivemall-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From takuti <...@git.apache.org>
Subject [GitHub] incubator-hivemall pull request #135: [WIP][HIVEMALL-145] Merge Brickhouse f...
Date Thu, 31 May 2018 07:12:19 GMT
Github user takuti commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/135#discussion_r192006959
  
    --- Diff: core/src/main/java/hivemall/tools/sanity/AssertUDF.java ---
    @@ -25,8 +25,10 @@
     
     @Description(name = "assert",
             value = "_FUNC_(boolean condition) or _FUNC_(boolean condition, string errMsg)"
    -                + "- Throws HiveException if condition is not met")
    -@UDFType(deterministic = true, stateful = false)
    +                + "- Throws HiveException if condition is not met",
    +        extended = "SELECT count(1) FROM stock_price WHERE assert(price > 0.0);\n"
    +                + "SELECT count(1) FROM stock_price WHRE assert(price > 0.0, 'price
MUST be more than 0.0')")
    --- End diff --
    
    typo `s/WHRE/WHERE/`


---

Mime
View raw message