hivemall-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From myui <...@git.apache.org>
Subject [GitHub] incubator-hivemall pull request #149: [WIP][HIVEMALL-201] Evaluate, fix and ...
Date Tue, 29 May 2018 03:43:49 GMT
Github user myui commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/149#discussion_r191298514
  
    --- Diff: core/src/main/java/hivemall/fm/FactorizationMachineUDTF.java ---
    @@ -379,23 +379,28 @@ protected void checkInputVector(@Nonnull final Feature[] x) throws
HiveException
             _model.check(x);
         }
     
    +    protected void processValidationSample(@Nonnull final Feature[] x, final double y)
    +            throws HiveException {
    +        if (_adaptiveRegularization) {
    +            trainLambda(x, y); // adaptive regularization
    --- End diff --
    
    `FFM fully ignores adaptive regularization option` is expected behavior.
    Not tested AdaptiveRegularization with FFM and/or FTRL.


---

Mime
View raw message