hivemall-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From myui <...@git.apache.org>
Subject [GitHub] incubator-hivemall pull request #146: [HIVEMALL-192] Fix typos: graphvis -> ...
Date Wed, 18 Apr 2018 04:51:46 GMT
Github user myui commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/146#discussion_r182308352
  
    --- Diff: core/src/main/java/hivemall/smile/tools/TreeExportUDF.java ---
    @@ -141,17 +141,17 @@ public String getDisplayString(String[] children) {
         }
     
         public enum OutputType {
    -        javascript, graphvis;
    +        javascript, graphviz;
     
             @Nonnull
             public static OutputType resolve(@Nonnull String name) throws UDFArgumentException
{
                 if ("js".equalsIgnoreCase(name) || "javascript".equalsIgnoreCase(name)) {
                     return javascript;
    -            } else if ("dot".equalsIgnoreCase(name) || "graphvis".equalsIgnoreCase(name))
{
    -                return graphvis;
    +            } else if ("dot".equalsIgnoreCase(name) || "graphviz".equalsIgnoreCase(name))
{
    --- End diff --
    
    better to have `"graphvis".equalsIgnoreCase(name)` for backward compatibility.


---

Mime
View raw message