hivemall-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From myui <...@git.apache.org>
Subject [GitHub] incubator-hivemall pull request #124: [HIVEMALL-157] Avoid Null Pointer Exce...
Date Wed, 01 Nov 2017 08:03:27 GMT
Github user myui commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/124#discussion_r148199276
  
    --- Diff: core/src/main/java/hivemall/tools/list/UDAFToOrderedList.java ---
    @@ -404,11 +407,9 @@ void merge(@Nonnull List<Object> o_keyList, @Nonnull List<Object>
o_valueList) {
                     }
                 }
     
    -            @Nonnull
                 Pair<List<Object>, List<Object>> drainQueue() {
    --- End diff --
    
    Add `@Nullable` for the return of `drainQueue` .


---

Mime
View raw message