hivemall-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From myui <...@git.apache.org>
Subject [GitHub] incubator-hivemall pull request #122: [HIVEMALL-147][Spark] Support all Hive...
Date Mon, 16 Oct 2017 06:47:09 GMT
Github user myui commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/122#discussion_r144765287
  
    --- Diff: core/src/main/java/hivemall/evaluation/AUCUDAF.java ---
    @@ -110,7 +110,7 @@ public ClassificationEvaluator() {}
     
             @Override
             public ObjectInspector init(Mode mode, ObjectInspector[] parameters) throws HiveException
{
    -            assert (parameters.length == 2 || parameters.length == 3) : parameters.length;
    +            assert (0 < parameters.length && parameters.length <= 3) :
parameters.length;
    --- End diff --
    
    It would be a bug and should use Preconditions. I guess enable assertion `-ea`  is not
enabled (cc: @takuti )


---

Mime
View raw message