hivemall-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maropu <...@git.apache.org>
Subject [GitHub] incubator-hivemall pull request #122: [HIVEMALL-147][Spark] Support all Hive...
Date Mon, 16 Oct 2017 04:40:03 GMT
Github user maropu commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/122#discussion_r144753835
  
    --- Diff: core/src/main/java/hivemall/evaluation/HitRateUDAF.java ---
    @@ -71,9 +71,6 @@
                     + " - Returns HitRate")
     public final class HitRateUDAF extends AbstractGenericUDAFResolver {
     
    -    // prevent instantiation
    -    private HitRateUDAF() {}
    -
    --- End diff --
    
    This prevents Spark from loading UDAFs by using reflection. Can we remove this?


---

Mime
View raw message