Mailing-List: contact issues-help@hivemall.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hivemall.incubator.apache.org
From: myui <git@git.apache.org>
To: issues@hivemall.incubator.apache.org
Reply-To: issues@hivemall.incubator.apache.org
References: <git-pr-111-incubator-hivemall@git.apache.org>
In-Reply-To: <git-pr-111-incubator-hivemall@git.apache.org>
Subject: [GitHub] incubator-hivemall pull request #111: [WIP][HIVEMALL-17] Support SLIM
Content-Type: text/plain
Message-Id: <20170830110708.1E219F5574@git1-us-west.apache.org>
Date: Wed, 30 Aug 2017 11:07:08 +0000 (UTC)
archived-at: Wed, 30 Aug 2017 11:07:12 -0000

Github user myui commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/111#discussion_r136028991
  
    --- Diff: core/src/main/java/hivemall/recommend/SlimUDTF.java ---
    @@ -217,13 +347,48 @@ private void train(int i, Map<?, ?> Ri, Map<?, ?> topKRatesOfI, int j, Map<?, ?>
                 double eui = rui - predict(u, i, topKRatesOfI, j);
                 gradSum += ruj * eui;
                 rateSum += ruj * ruj;
    -            errs += eui * eui;
    +
    +            if (this.numIterations > 1){
    +                this.A.unsafeSet((int) u, j, ruj); // need optimize
    --- End diff --
    
    use OI to get `u`. `(int) u` would fail.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---