hivemall-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From takuti <...@git.apache.org>
Subject [GitHub] incubator-hivemall pull request #110: [HIVEMALL-142] Implement SingularizeUD...
Date Mon, 28 Aug 2017 05:48:40 GMT
GitHub user takuti opened a pull request:

    https://github.com/apache/incubator-hivemall/pull/110

    [HIVEMALL-142] Implement SingularizeUDF

    ## What changes were proposed in this pull request?
    
    Implement `singularize(string word)` to obtain singular form of `word`.
    
    The implementation referred the following third-party code:
    
    - https://github.com/sundrio/sundrio/blob/95c2b11f7b842bdaa04f61e8e338aea60fb38f70/codegen/src/main/java/io/sundr/codegen/functions/Singularize.java
    - https://github.com/clips/pattern/blob/3eef00481a4555331cf9a099308910d977f6fc22/pattern/text/en/inflect.py#L445-L623
    
    ## What type of PR is it?
    
    Feature
    
    ## What is the Jira issue?
    
    https://issues.apache.org/jira/browse/HIVEMALL-142
    
    ## How was this patch tested?
    
    unit test & manual test on EMR
    
    ## How to use this feature?
    
    as documented
    
    ## Checklist
    
    - [x] Did you apply source code formatter, i.e., `mvn formatter:format`, for your commit?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/takuti/incubator-hivemall singularize

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hivemall/pull/110.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #110
    
----
commit 796d388c36c520858b6e61deb34100cb9201e5fa
Author: Takuya Kitazawa <k.takuti@gmail.com>
Date:   2017-08-28T05:41:43Z

    Fix StringUtils.concat() to remove tail unnecessary separator

commit b14ca0975ddc65f0b208ae16734e8f77fb0c126d
Author: Takuya Kitazawa <k.takuti@gmail.com>
Date:   2017-08-28T05:43:51Z

    Implement SingularizeUDF

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message