Mailing-List: contact issues-help@hivemall.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hivemall.incubator.apache.org
From: myui <git@git.apache.org>
To: issues@hivemall.incubator.apache.org
Reply-To: issues@hivemall.incubator.apache.org
References: <git-pr-97-incubator-hivemall@git.apache.org>
In-Reply-To: <git-pr-97-incubator-hivemall@git.apache.org>
Subject: [GitHub] incubator-hivemall pull request #97: [HIVEMALL-130] Support user-defined dic...
Content-Type: text/plain
Message-Id: <20170713034150.6839CDFC28@git1-us-west.apache.org>
Date: Thu, 13 Jul 2017 03:41:50 +0000 (UTC)
archived-at: Thu, 13 Jul 2017 03:41:55 -0000

Github user myui commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/97#discussion_r127121983
  
    --- Diff: core/src/main/java/hivemall/utils/io/BoundedInputStream.java ---
    @@ -0,0 +1,117 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package hivemall.utils.io;
    +
    +import java.io.IOException;
    +import java.io.InputStream;
    +
    +/**
    + * Input stream which only supplies bytes up to a certain length
    + * Implementation is based on BoundedInputStream in Apache Commons IO
    + * https://commons.apache.org/proper/commons-io/javadocs/api-2.5/org/apache/commons/io/input/BoundedInputStream.html
    + */
    +public final class BoundedInputStream extends InputStream {
    --- End diff --
    
    checksum of gzip is correct but your Boundedinputstream Could return unexpected eof. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---