Mailing-List: contact issues-help@hivemall.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hivemall.incubator.apache.org
From: takuti <git@git.apache.org>
To: issues@hivemall.incubator.apache.org
Reply-To: issues@hivemall.incubator.apache.org
References: <git-pr-97-incubator-hivemall@git.apache.org>
In-Reply-To: <git-pr-97-incubator-hivemall@git.apache.org>
Subject: [GitHub] incubator-hivemall pull request #97: [HIVEMALL-130] Support user-defined dic...
Content-Type: text/plain
Message-Id: <20170711081400.D8C74E024D@git1-us-west.apache.org>
Date: Tue, 11 Jul 2017 08:14:00 +0000 (UTC)
archived-at: Tue, 11 Jul 2017 08:14:07 -0000

Github user takuti commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/97#discussion_r126622639
  
    --- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
    @@ -239,6 +239,16 @@ private static UserDictionary userDictionary(@Nullable final String userDictURL)
             conn.setConnectTimeout(CONNECT_TIMEOUT_MS); // throw exception from connect()
             conn.setReadTimeout(READ_TIMEOUT_MS); // throw exception from getXXX() methods
     
    +        final int responseCode;
    +        try {
    +            responseCode = conn.getResponseCode();
    +        } catch (Throwable e) {
    +            throw new UDFArgumentException("Failed to get response code: " + e);
    +        }
    +        if (responseCode != 200) {
    +            throw new UDFArgumentException("God invalid response code: " + responseCode);
    --- End diff --
    
    OMG, it's typo lol


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---