hivemall-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From myui <...@git.apache.org>
Subject [GitHub] incubator-hivemall pull request #97: [HIVEMALL-130] Support user-defined dic...
Date Thu, 13 Jul 2017 06:19:24 GMT
Github user myui commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/97#discussion_r127132855
  
    --- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
    @@ -170,6 +192,86 @@ private static CharArraySet stopWords(@Nonnull final String[] array)
             return results;
         }
     
    +    @Nullable
    +    private static UserDictionary userDictionary(@Nonnull final ObjectInspector oi)
    +            throws UDFArgumentException {
    +        if (HiveUtils.isConstListOI(oi)) {
    +            return userDictionary(HiveUtils.getConstStringArray(oi));
    +        } else if (HiveUtils.isConstString(oi)) {
    +            return userDictionary(HiveUtils.getConstString(oi));
    +        } else {
    +            throw new UDFArgumentException(
    +                "User dictionary MUST be given as an array of constant string or constant
string (URL)");
    +        }
    +    }
    +
    +    @Nullable
    +    private static UserDictionary userDictionary(@Nullable final String[] userDictArray)
    +            throws UDFArgumentException {
    +        if (userDictArray == null) {
    +            return null;
    +        }
    +
    +        StringBuilder builder = new StringBuilder();
    +        for (String row : userDictArray) {
    +            builder.append(row);
    +            builder.append("\n");
    +        }
    +        InputStream is = new FastByteArrayInputStream(builder.toString().getBytes());
    +        final Reader reader = new InputStreamReader(is);
    +        try {
    +            return UserDictionary.open(reader); // return null if empty
    +        } catch (Throwable e) {
    +            throw new UDFArgumentException(
    +                "Failed to create user dictionary based on the given array<string>:
" + e);
    +        }
    +    }
    +
    +    @Nullable
    +    private static UserDictionary userDictionary(@Nullable final String userDictURL)
    +            throws UDFArgumentException {
    +        if (userDictURL == null) {
    +            return null;
    +        }
    +
    +        final HttpURLConnection conn;
    +        try {
    +            conn = HttpUtils.getHttpURLConnection(userDictURL);
    +        } catch (Throwable e) {
    +            throw new UDFArgumentException("Failed to create HTTP connection to the URL:
" + e);
    +        }
    +
    +        // allow to read as a compressed GZIP file for efficiency
    +        conn.setRequestProperty("Accept-Encoding", "gzip");
    +
    +        conn.setConnectTimeout(CONNECT_TIMEOUT_MS); // throw exception from connect()
    +        conn.setReadTimeout(READ_TIMEOUT_MS); // throw exception from getXXX() methods
    +
    +        final int responseCode;
    +        try {
    +            responseCode = conn.getResponseCode();
    +        } catch (Throwable e) {
    +            throw new UDFArgumentException("Failed to get response code: " + e);
    +        }
    +        if (responseCode != 200) {
    +            throw new UDFArgumentException("Got invalid response code: " + responseCode);
    +        }
    +
    +        final InputStream is;
    +        try {
    +            is = IOUtils.decompressStream(HttpUtils.getLimitedInputStream(conn, MAX_INPUT_STREAM_SIZE));
    +        } catch (Throwable e) {
    --- End diff --
    
    Is not `IOException` enough?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message