hivemall-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From myui <...@git.apache.org>
Subject [GitHub] incubator-hivemall pull request #97: [HIVEMALL-130] Support user-defined dic...
Date Thu, 13 Jul 2017 06:19:24 GMT
Github user myui commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/97#discussion_r127134755
  
    --- Diff: core/src/main/java/hivemall/utils/io/LimitedInputStream.java ---
    @@ -0,0 +1,106 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package hivemall.utils.io;
    +
    +import javax.annotation.Nonnegative;
    +import java.io.IOException;
    +import java.io.InputStream;
    +
    +/**
    + * Input stream which is limited to a certain length
    + * Implementation is based on BoundedInputStream in Apache Commons IO and LimitedInputStream
in Apache Commons FileUpload
    + *
    + * @link https://commons.apache.org/proper/commons-io/javadocs/api-2.5/org/apache/commons/io/input/BoundedInputStream.html
    + * @link https://commons.apache.org/proper/commons-fileupload/apidocs/org/apache/commons/fileupload/util/LimitedInputStream.html
    + */
    +public final class LimitedInputStream extends InputStream {
    --- End diff --
    
    I like the original design of https://github.com/apache/commons-fileupload/blob/master/src/main/java/org/apache/commons/fileupload/util/LimitedInputStream.java#L65
that `raiseError` can override (customizable).
    
    So, make `LimitedInputStream` class not final and create the default `raiseError` method.
    
    ```java
        protected void raiseError(long pos) throws IOException {
           throw new IOException("Exceeded maximum size of input stream: max=" + max ", pos="+
pos);
        }
    
        private void proceed(@Nonnegative long bytes) throws IOException {
             this.pos += bytes;
             if (pos > max) {
                 raiseError(pos);
             }
        }
    ```
    
    Example usage is as follows:
    
    ```java
    new LimitedInputStream() {
       @Override
       protected void raiseError(long pos) throws IOException {
          logger.error(xxx);
          throw new IOException(...);
       }
    };
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message