hivemall-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From myui <...@git.apache.org>
Subject [GitHub] incubator-hivemall pull request #95: [HIVEMALL-119] Fix type cast issues in ...
Date Thu, 06 Jul 2017 08:59:30 GMT
Github user myui commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/95#discussion_r125845977
  
    --- Diff: xgboost/src/main/java/hivemall/xgboost/XGBoostUDTF.java ---
    @@ -269,44 +274,33 @@ public void checkTargetValue(double target) throws HiveException
{}
         public void process(Object[] args) throws HiveException {
             if (args[0] != null) {
                 // TODO: Need to support dense inputs
    -            final List<String> features = (List<String>) featureListOI.getList(args[0]);
    +            final List<?> features = (List<?>) featureListOI.getList(args[0]);
    +            final String[] fv = new String[features.size()];
    +            for (int i = 0; i < features.size(); i++) {
    +                fv[i] = (String) featureElemOI.getPrimitiveJavaObject(features.get(i));
    +            }
                 double target = PrimitiveObjectInspectorUtils.getDouble(args[1], this.targetOI);
                 checkTargetValue(target);
    -            final LabeledPoint point = XGBoostUtils.parseFeatures(target, features);
    +            final LabeledPoint point = XGBoostUtils.parseFeatures(target, fv);
                 if (point != null) {
                     this.featuresList.add(point);
                 }
             }
         }
     
    -    /**
    -     * Need to override this for a Spark wrapper because `MapredContext` does not work
in there.
    -     */
    -    protected String generateUniqueModelId() {
    -        return "xgbmodel-" + String.valueOf(HadoopUtils.getTaskId());
    +    private String generateUniqueModelId() {
    +        return "xgbmodel-" + taskId + "-" + RandomUtils.getUUID() + "-" + sequence++;
    --- End diff --
    
    Ah, multiple models are created in a single task. So, `sequence` is required.
    
    `taskId` could be useful just in case UUIDs are corrupting. So, okey as it is. 
    
    So, `"xgbmodel-" + taskId + "-" + HadoopUtils.getUniqueTaskIdString() + "-" + sequence++;"`
?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message