hivemall-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From takuti <...@git.apache.org>
Subject [GitHub] incubator-hivemall pull request #85: [HIVEMALL-115] Fix ranking AUC for all ...
Date Thu, 08 Jun 2017 03:54:19 GMT
GitHub user takuti opened a pull request:

    https://github.com/apache/incubator-hivemall/pull/85

    [HIVEMALL-115] Fix ranking AUC for all TP/FP recommendation

    ## What changes were proposed in this pull request?
    
    The current ranking AUC returns NULL when all recommended items are TP (or FP). This PR
fixes the issue by returning 0.5 as "meaningless" AUC for such input.
    
    - Caused by: myui/hivemall#326
    - Reference:
      - [LibRec](https://github.com/guoguibing/librec/blob/18176ed41027348ee2187d8686a1b2c0d4d39277/core/src/main/java/net/librec/eval/ranking/AUCEvaluator.java#L80-L83)
      - [MyMediaLite](https://github.com/zenogantner/MyMediaLite/blob/3a268110338b24627c8c2c973c0f9d03b151e2df/src/MyMediaLite/Eval/Measures/AUC.cs#L51-L52)
    
    ## What type of PR is it?
    
    Bug Fix
    
    ## What is the Jira issue?
    
    https://issues.apache.org/jira/browse/HIVEMALL-115
    
    ## How was this patch tested?
    
    Manually (local & EMR)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/takuti/incubator-hivemall fix-auc-ranking

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hivemall/pull/85.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #85
    
----
commit 36519bc9e418fa2d93abf62d9c39f5756dcf17a9
Author: Takuya Kitazawa <k.takuti@gmail.com>
Date:   2017-06-08T03:42:11Z

    Return AUC=0.5 for all TP/FP recommendation

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message