hivemall-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From takuti <...@git.apache.org>
Subject [GitHub] incubator-hivemall issue #82: Encoding related bug in LDA.
Date Fri, 02 Jun 2017 06:55:51 GMT
Github user takuti commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/82
  
    @helenahm Good catch, and thank you for reporting. You are right; this bug is definitely
caused by the encoding-related issue. I'll take care of fixing the bug.
    
    Basically, the critical reason is in:
    
    ```java
    buf.putInt(wc.length());
    buf.put(wc.getBytes());
    ```
    
    These lines are totally wrong and need be fixed to:
    
    ```java
    buf.putInt(wc.getBytes().length);
    buf.put(wc.getBytes());
    ```
    
    At the same time, as @myui mentioned above, using `bytes` things should be avoided.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message