hivemall-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From takuti <...@git.apache.org>
Subject [GitHub] incubator-hivemall pull request #76: [HIVEMALL-74-2][HIVEMALL-91-2] Revise t...
Date Sat, 29 Apr 2017 09:33:38 GMT
GitHub user takuti opened a pull request:

    https://github.com/apache/incubator-hivemall/pull/76

    [HIVEMALL-74-2][HIVEMALL-91-2] Revise topic model UDFs

    ## What changes were proposed in this pull request?
    
    Revising topic model UDFs implemented in #66 (LDA) and #71 (pLSA)
    
    - Fix CI failure
    - Refactors
    - Update docs 
    
    ## What type of PR is it?
    
    Documentation, Hot Fix, Refactoring
    
    ## What is the Jira issue?
    
    - https://issues.apache.org/jira/browse/HIVEMALL-74
    - https://issues.apache.org/jira/browse/HIVEMALL-91
    
    ## How was this patch tested?
    
    - Manual tests
    - Unit tests


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/takuti/incubator-hivemall topicmodel-revise

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hivemall/pull/76.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #76
    
----
commit bf9dcfcf202adcb1943957cd78c4f75936e7dd13
Author: Takuya Kitazawa <k.takuti@gmail.com>
Date:   2017-04-28T05:28:46Z

    Ensure the same interface as pLSA predict UDAF to LDA

commit f9b246b0ed366cd4b90df92643a2109e3a4ee10e
Author: Takuya Kitazawa <k.takuti@gmail.com>
Date:   2017-04-28T05:35:41Z

    Remove "w/o -topics option" test cases
    
    Default #topics will be used in case it's not specified

commit 52bfe6548ef2db5eac41782fc8b7f1ab6d3fdafc
Author: Takuya Kitazawa <k.takuti@gmail.com>
Date:   2017-04-29T09:00:05Z

    Fix for a case that options are not specified
    
    Add test cases accordingly

commit 1338dee92b0bd366960cef7de271831d7ba4202b
Author: Takuya Kitazawa <k.takuti@gmail.com>
Date:   2017-04-29T09:23:56Z

    Refactor

commit 68af6b44907eedcefe0ba24fffe8f41075c8a833
Author: Takuya Kitazawa <k.takuti@gmail.com>
Date:   2017-04-29T09:29:45Z

    Update doc for LDA and `-topics` option

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message