hivemall-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From myui <...@git.apache.org>
Subject [GitHub] incubator-hivemall pull request #66: [HIVEMALL-91] Implement Online LDA
Date Wed, 19 Apr 2017 07:37:17 GMT
Github user myui commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/66#discussion_r112127661
  
    --- Diff: core/src/main/java/hivemall/topicmodel/OnlineLDAModel.java ---
    @@ -0,0 +1,530 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package hivemall.topicmodel;
    +
    +import hivemall.annotations.VisibleForTesting;
    +import hivemall.model.FeatureValue;
    +import hivemall.utils.lang.ArrayUtils;
    +import hivemall.utils.math.MathUtils;
    +
    +import java.util.ArrayList;
    +import java.util.Collections;
    +import java.util.HashMap;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.SortedMap;
    +import java.util.TreeMap;
    +
    +import javax.annotation.Nonnegative;
    +import javax.annotation.Nonnull;
    +
    +import org.apache.commons.math3.distribution.GammaDistribution;
    +import org.apache.commons.math3.special.Gamma;
    +
    +public final class OnlineLDAModel {
    +
    +    // number of topics
    +    private int _K;
    +
    +    // prior on weight vectors "theta ~ Dir(alpha_)"
    +    private float _alpha = 1 / 2.f;
    +
    +    // prior on topics "beta"
    +    private float _eta = 1 / 20.f;
    --- End diff --
    
    Better to fix values as final in constructor.
    
    ```java
        // number of topics
        private final int _K;
    
        // prior on weight vectors "theta ~ Dir(alpha_)"
        private final float _alpha;
    
        // prior on topics "beta"
        private final float _eta;
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message