Mailing-List: contact issues-help@hivemall.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hivemall.incubator.apache.org
From: myui <git@git.apache.org>
To: issues@hivemall.incubator.apache.org
Reply-To: issues@hivemall.incubator.apache.org
References: <git-pr-61-incubator-hivemall@git.apache.org>
In-Reply-To: <git-pr-61-incubator-hivemall@git.apache.org>
Subject: [GitHub] incubator-hivemall pull request #61: [HIVEMALL-88][SPARK] Support a function...
Content-Type: text/plain
Message-Id: <20170309052946.736BADFE5C@git1-us-west.apache.org>
Date: Thu,  9 Mar 2017 05:29:46 +0000 (UTC)
archived-at: Thu, 09 Mar 2017 05:30:06 -0000

Github user myui commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/61#discussion_r105089215
  
    --- Diff: spark/spark-2.1/src/main/scala/org/apache/spark/sql/hive/HivemallOps.scala ---
    @@ -805,6 +805,47 @@ final class HivemallOps(df: DataFrame) extends Logging {
         JoinTopK(kInt, df.logicalPlan, right.logicalPlan, Inner, Option(joinExprs.expr))(score.named)
       }
     
    +  private def doFlatten(schema: StructType, prefix: Option[String] = None) : Seq[Column] = {
    +    schema.fields.flatMap { f =>
    +      val colName = prefix.map(p => s"$p.${f.name}").getOrElse(f.name)
    --- End diff --
    
    ??? flatten'ed column names are not a Spark specification. Better to have a ability to use a custom separator.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---