Mailing-List: contact issues-help@hivemall.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hivemall.incubator.apache.org
From: myui <git@git.apache.org>
To: issues@hivemall.incubator.apache.org
Reply-To: issues@hivemall.incubator.apache.org
References: <git-pr-52-incubator-hivemall@git.apache.org>
In-Reply-To: <git-pr-52-incubator-hivemall@git.apache.org>
Subject: [GitHub] incubator-hivemall pull request #52: [HIVEMALL-78] Implement AUC UDAF for bi...
Content-Type: text/plain
Message-Id: <20170228071406.0E3FDDFDE6@git1-us-west.apache.org>
Date: Tue, 28 Feb 2017 07:14:06 +0000 (UTC)
archived-at: Tue, 28 Feb 2017 07:14:15 -0000

Github user myui commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/52#discussion_r103389250
  
    --- Diff: core/src/main/java/hivemall/evaluation/AUCUDAF.java ---
    @@ -49,35 +50,251 @@
     @SuppressWarnings("deprecation")
     @Description(
             name = "auc",
    -        value = "_FUNC_(array rankItems, array correctItems [, const int recommendSize = rankItems.size])"
    +        value = "_FUNC_(array rankItems | double score, array correctItems | double label "
    +                + "[, const int recommendSize = rankItems.size ])"
                     + " - Returns AUC")
     public final class AUCUDAF extends AbstractGenericUDAFResolver {
     
    -    // prevent instantiation
    -    private AUCUDAF() {}
    -
         @Override
         public GenericUDAFEvaluator getEvaluator(@Nonnull TypeInfo[] typeInfo) throws SemanticException {
             if (typeInfo.length != 2 && typeInfo.length != 3) {
                 throw new UDFArgumentTypeException(typeInfo.length - 1,
                     "_FUNC_ takes two or three arguments");
             }
     
    -        ListTypeInfo arg1type = HiveUtils.asListTypeInfo(typeInfo[0]);
    -        if (!HiveUtils.isPrimitiveTypeInfo(arg1type.getListElementTypeInfo())) {
    -            throw new UDFArgumentTypeException(0,
    -                "The first argument `array rankItems` is invalid form: " + typeInfo[0]);
    +        if (HiveUtils.isNumberTypeInfo(typeInfo[0]) && HiveUtils.isNumberTypeInfo(typeInfo[1])) {
    --- End diff --
    
    `&& HiveUtils.isIntegerTypeInfo(typeInfo[1])`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---