hivemall-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maropu <...@git.apache.org>
Subject [GitHub] incubator-hivemall pull request #31: [HIVEMALL-40] Load xgboost-formatted da...
Date Thu, 26 Jan 2017 16:15:38 GMT
GitHub user maropu opened a pull request:

    https://github.com/apache/incubator-hivemall/pull/31

    [HIVEMALL-40] Load xgboost-formatted data via Java ServiceLoader

    ## What changes were proposed in this pull request?
    In the mater, we need to directly set an explicit implementation class for loading xgboost-formatted
data. This pr modified code to resolve the class via Java ServiceLoader.
    
    ## What type of PR is it?
    Improvement
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/HIVEMALL-40
    
    ## How was this patch tested?
    Added a test to resolve an implementation class to load xgboost-formatted data in `XGBoostSuite.scala`.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/maropu/incubator-hivemall HIVEMALL-40

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hivemall/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #31
    
----
commit d0cbf3db2cb4ce6bcca88a8ed45488a016e9960e
Author: Takeshi YAMAMURO <linguin.m.s@gmail.com>
Date:   2017-01-26T16:01:14Z

    Load xgboost-formatted data via Java ServiceLoader

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message