Mailing-List: contact user-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@hive.apache.org
Received-SPF: pass (athena.apache.org: domain of grover.markgrover@gmail.com
 designates 209.85.220.172 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CA++PF=NfeYD4e4BmbVh+CRQmEmN9pX=Wvy-1iC=q9m6QKGLROg@mail.gmail.com>
References: 
 <CA++PF=No8YD52fXp_Q8ZTN09m584iX5QoovaoSnh==cDdQEc9A@mail.gmail.com>
	<CABnfPO4ZV6pVxkF5cORV5ABqHrER-4n0+RNPRHP-Bhoo9d3=ww@mail.gmail.com>
	<CA++PF=Nn7oTRyR8D=2uK+0n8aGS4FRDT+6Rr-W-5uic_9Uir1Q@mail.gmail.com>
	<CA++PF=M-AY6=odGY906RL6AH5T9T3qYebdWbrSi5oPwgD6dRmA@mail.gmail.com>
	<CAKm=R7WedHpHi+ybZKyqnCingjESMpKwHErMPLukLxD7EfA3AQ@mail.gmail.com>
	<CA++PF=NfeYD4e4BmbVh+CRQmEmN9pX=Wvy-1iC=q9m6QKGLROg@mail.gmail.com>
Date: Mon, 17 Dec 2012 21:27:19 -0800
Message-ID: 
 <CAKm=R7X1J1gdgwL=e07bbaCJ8C0e0SK9O3HrX-aM8OThdMi27Q@mail.gmail.com>
Subject: Re: HiveHistory and HiveHistoryViewer
From: Mark Grover <grover.markgrover@gmail.com>
To: user@hive.apache.org
Content-Type: text/plain; charset=ISO-8859-1

Qiang,
Good point. Uploaded a new patch.
Thanks!

On Mon, Dec 17, 2012 at 9:14 PM, Qiang Wang <wsxys08@gmail.com> wrote:
> "HiveHistory.parseHiveHistory use BufferedReader.readLine which takes '\n',
> '\r', '\r\n' as line delimiter to parse history file"
>
> And clients may be on mac, which takes '\r' as line delimiter
>
> So I think '\r' should also be replaced with space in  HiveHistory.log, so
> that HiveHistory.parseHiveHistory could be consistent with HiveHistory.log
> and allow clients from mac
>
> Thanks!
>
>
> 2012/12/18 Mark Grover <grover.markgrover@gmail.com>
>>
>> Looks like a bug to me. This is the original JIRA that introduced this
>> change:
>> https://issues.apache.org/jira/browse/HIVE-176
>>
>> I don't think back in the day, we really cared about clients being on
>> windows.
>>
>> In any case, thanks for filing the JIRA, I have uploaded a patch which
>> I think doesn't break anything for linux clients and fixes things up
>> for Windows clients. Take a look, feedback welcome. The intent is the
>> same as your suggestions but the approach is a little more
>> conservative. If you feel strongly that it should be done according to
>> one of your suggestions, let me know, I will take another look.
>>
>> Thanks!
>> Mark
>>
>> On Mon, Dec 17, 2012 at 5:48 AM, Qiang Wang <wsxys08@gmail.com> wrote:
>> > anybody has an idea about this ?
>> >
>> > https://issues.apache.org/jira/browse/HIVE-3810
>> >
>> >
>> >
>> > 2012/12/16 Qiang Wang <wsxys08@gmail.com>
>> >>
>> >> glad to receive your reply!
>> >>
>> >> here is my point:
>> >> Firstly, I think HiveHistoryViewer is inconsistent with HiveHistory.
>> >> Secondly, hive server may be deloyed on linux, but client can be
>> >> anywhere.
>> >> hql from client will be logged into history file and hql may contails
>> >> '\r'
>> >>
>> >>
>> >> 2012/12/16 afancy <groupme@gmail.com>
>> >>>
>> >>> I don\t think it is a bug. If the program in hive writes logs to
>> >>> HiveHistory.log using '\n' to indicate the end of a line. Then, it is
>> >>> OK to
>> >>> use val = val.replace('\n', ' ');.  Anyway,
>> >>> new line depends what on your OS: Hive is typically deployed on Linux.
>> >>> DOS & Windows: \r\n 0D0A (hex), 13,10 (decimal)
>> >>>
>> >>> Unix & Mac OS X: \n, 0A, 10
>> >>> Macintosh (OS 9): \r, 0D, 13
>> >>>
>> >>> On Sun, Dec 16, 2012 at 11:23 AM, Qiang Wang <wsxys08@gmail.com>
>> >>> wrote:
>> >>>>
>> >>>> '\n', '\r',
>> >>>
>> >>>
>> >>>
>> >>>
>> >>
>> >
>
>