hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-25325) Add TRUNCATE TABLE support for Hive Iceberg tables
Date Mon, 19 Jul 2021 14:35:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-25325?focusedWorklogId=624399&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-624399
]

ASF GitHub Bot logged work on HIVE-25325:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Jul/21 14:34
            Start Date: 19/Jul/21 14:34
    Worklog Time Spent: 10m 
      Work Description: marton-bod commented on a change in pull request #2471:
URL: https://github.com/apache/hive/pull/2471#discussion_r672354549



##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -3360,42 +3360,50 @@ public CmRecycleResponse cm_recycle(final CmRecycleRequest request)
throws MetaE
   public void truncate_table(final String dbName, final String tableName, List<String>
partNames)
       throws NoSuchObjectException, MetaException {
     // Deprecated path, won't work for txn tables.
-    truncateTableInternal(dbName, tableName, partNames, null, -1);
+    truncateTableInternal(dbName, tableName, partNames, null, -1, null);
   }
 
   @Override
   public TruncateTableResponse truncate_table_req(TruncateTableRequest req)
       throws MetaException, TException {
     truncateTableInternal(req.getDbName(), req.getTableName(), req.getPartNames(),
-        req.getValidWriteIdList(), req.getWriteId());
+        req.getValidWriteIdList(), req.getWriteId(), req.getEnvironmentContext());
     return new TruncateTableResponse();
   }
 
   private void truncateTableInternal(String dbName, String tableName, List<String>
partNames,
-                                     String validWriteIds, long writeId) throws MetaException,
NoSuchObjectException {
+                                     String validWriteIds, long writeId, EnvironmentContext
context) throws MetaException, NoSuchObjectException {
     boolean isSkipTrash = false, needCmRecycle = false;
     try {
       String[] parsedDbName = parseDbName(dbName, conf);
       Table tbl = get_table_core(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName);
 
-      boolean truncateFiles = !TxnUtils.isTransactionalTable(tbl) ||
-          !MetastoreConf.getBoolVar(getConf(), MetastoreConf.ConfVars.TRUNCATE_ACID_USE_BASE);
-
-      if (truncateFiles) {
-        isSkipTrash = MetaStoreUtils.isSkipTrash(tbl.getParameters());
-        Database db = get_database_core(parsedDbName[CAT_NAME], parsedDbName[DB_NAME]);
-        needCmRecycle = ReplChangeManager.shouldEnableCm(db, tbl);
+      boolean skipDataDeletion = false;
+      if (context != null && context.getProperties() != null

Review comment:
       In that case, if you get a null at any point during the map operation, it will fall
back to the bottom `orElse` part right away




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 624399)
    Time Spent: 1h 50m  (was: 1h 40m)

> Add TRUNCATE TABLE support for Hive Iceberg tables
> --------------------------------------------------
>
>                 Key: HIVE-25325
>                 URL: https://issues.apache.org/jira/browse/HIVE-25325
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Marta Kuczora
>            Assignee: Marta Kuczora
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Implement the TRUNCATE operation for Hive Iceberg tables. Since these tables are unpartitioned
in Hive, only the truncate unpartitioned table use case has to be supported.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message