hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-24302) Cleaner shouldn't run if it can't remove obsolete files
Date Mon, 04 Jan 2021 01:11:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-24302?focusedWorklogId=530498&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-530498
]

ASF GitHub Bot logged work on HIVE-24302:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Jan/21 01:10
            Start Date: 04/Jan/21 01:10
    Worklog Time Spent: 10m 
      Work Description: github-actions[bot] closed pull request #1612:
URL: https://github.com/apache/hive/pull/1612


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 530498)
    Time Spent: 50m  (was: 40m)

> Cleaner shouldn't run if it can't remove obsolete files
> -------------------------------------------------------
>
>                 Key: HIVE-24302
>                 URL: https://issues.apache.org/jira/browse/HIVE-24302
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Karen Coppage
>            Assignee: Karen Coppage
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Example:
>  # open txn 5, leave it open (maybe it's a long-running compaction)
>  # insert into table t in txns 6, 7 with writeids 1, 2
>  # compactor.Worker runs on table t and compacts writeids 1, 2
>  # compactor.Cleaner picks up the compaction queue entry, but doesn't delete any files
because the min global open txnid is 5, which cannot see writeIds 1, 2.
>  # Cleaner marks the compactor queue entry as cleaned and removes the entry from the
queue.
> delta_1 and delta_2 will remain in the file system until another compaction is run on
table t.
> Step 5 should not happen, we should skip calling markCleaned() and leave it in the queue
in "ready to clean" state. MarkCleaned() should be called only after txn 5 is closed and,
following that, the cleaner runs successfully.
> This will potentially slow down the cleaner, but on the other hand it won't silently
"fail" i.e. not do its job.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message