hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-22981) DataFileReader is not closed in AvroGenericRecordReader#extractWriterTimezoneFromMetadata
Date Thu, 19 Nov 2020 07:43:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-22981?focusedWorklogId=513980&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-513980
]

ASF GitHub Bot logged work on HIVE-22981:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Nov/20 07:42
            Start Date: 19/Nov/20 07:42
    Worklog Time Spent: 10m 
      Work Description: findepi commented on pull request #1686:
URL: https://github.com/apache/hive/pull/1686#issuecomment-730190864


   @kgyrtkirk can you please help analyze the test failure? is there something that needs
to be changed in this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 513980)
    Time Spent: 20m  (was: 10m)

> DataFileReader is not closed in AvroGenericRecordReader#extractWriterTimezoneFromMetadata
> -----------------------------------------------------------------------------------------
>
>                 Key: HIVE-22981
>                 URL: https://issues.apache.org/jira/browse/HIVE-22981
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Karen Coppage
>            Assignee: Karen Coppage
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>         Attachments: HIVE-22981.01.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Method looks like :
> {code}
>  private ZoneId extractWriterTimezoneFromMetadata(JobConf job, FileSplit split,
>       GenericDatumReader<GenericRecord> gdr) throws IOException {
>     if (job == null || gdr == null || split == null || split.getPath() == null) {
>       return null;
>     }
>     try {
>       DataFileReader<GenericRecord> dataFileReader =
>           new DataFileReader<GenericRecord>(new FsInput(split.getPath(), job),
gdr);
>       [...return...]
>       }
>     } catch (IOException e) {
>       // Can't access metadata, carry on.
>     }
>     return null;
>   }
> {code}
> The DataFileReader is never closed which can cause a memory leak. We need a try-with-resources
here.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message