hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-24143) Include convention in JDBC converter operator in Calcite plan
Date Sat, 12 Sep 2020 21:36:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-24143?focusedWorklogId=483227&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-483227
]

ASF GitHub Bot logged work on HIVE-24143:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Sep/20 21:35
            Start Date: 12/Sep/20 21:35
    Worklog Time Spent: 10m 
      Work Description: vineetgarg02 commented on a change in pull request #1482:
URL: https://github.com/apache/hive/pull/1482#discussion_r487292490



##########
File path: ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##########
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND "d_date_sk"
IS NOT NULL) A
             Reduce Operator Tree:
               Merge Join Operator
                 condition map:
-                     Anti Join 0 to 1
+                     Left Outer Join 0 to 1

Review comment:
       Also not sure what caused this change in plan.

##########
File path: ql/src/test/queries/clientpositive/external_jdbc_table2.q
##########
@@ -7,43 +6,43 @@ CREATE TEMPORARY FUNCTION dboutput AS 'org.apache.hadoop.hive.contrib.genericudf
 
 FROM src
 SELECT
-dboutput ('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1;create=true','user1','passwd1',
+dboutput ('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1_1;create=true','user1','passwd1',

Review comment:
       Curious as to why this changed?

##########
File path: ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##########
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND "d_date_sk"
IS NOT NULL) A
             Reduce Operator Tree:
               Merge Join Operator
                 condition map:
-                     Anti Join 0 to 1
+                     Left Outer Join 0 to 1

Review comment:
       Got it, make sense

##########
File path: ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##########
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND "d_date_sk"
IS NOT NULL) A
             Reduce Operator Tree:
               Merge Join Operator
                 condition map:
-                     Anti Join 0 to 1
+                     Left Outer Join 0 to 1

Review comment:
       Also not sure what caused this change in plan.

##########
File path: ql/src/test/queries/clientpositive/external_jdbc_table2.q
##########
@@ -7,43 +6,43 @@ CREATE TEMPORARY FUNCTION dboutput AS 'org.apache.hadoop.hive.contrib.genericudf
 
 FROM src
 SELECT
-dboutput ('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1;create=true','user1','passwd1',
+dboutput ('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1_1;create=true','user1','passwd1',

Review comment:
       Curious as to why this changed?

##########
File path: ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##########
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND "d_date_sk"
IS NOT NULL) A
             Reduce Operator Tree:
               Merge Join Operator
                 condition map:
-                     Anti Join 0 to 1
+                     Left Outer Join 0 to 1

Review comment:
       Got it, make sense

##########
File path: ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##########
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND "d_date_sk"
IS NOT NULL) A
             Reduce Operator Tree:
               Merge Join Operator
                 condition map:
-                     Anti Join 0 to 1
+                     Left Outer Join 0 to 1

Review comment:
       Also not sure what caused this change in plan.

##########
File path: ql/src/test/queries/clientpositive/external_jdbc_table2.q
##########
@@ -7,43 +6,43 @@ CREATE TEMPORARY FUNCTION dboutput AS 'org.apache.hadoop.hive.contrib.genericudf
 
 FROM src
 SELECT
-dboutput ('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1;create=true','user1','passwd1',
+dboutput ('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1_1;create=true','user1','passwd1',

Review comment:
       Curious as to why this changed?

##########
File path: ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##########
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND "d_date_sk"
IS NOT NULL) A
             Reduce Operator Tree:
               Merge Join Operator
                 condition map:
-                     Anti Join 0 to 1
+                     Left Outer Join 0 to 1

Review comment:
       Got it, make sense

##########
File path: ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##########
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND "d_date_sk"
IS NOT NULL) A
             Reduce Operator Tree:
               Merge Join Operator
                 condition map:
-                     Anti Join 0 to 1
+                     Left Outer Join 0 to 1

Review comment:
       Also not sure what caused this change in plan.

##########
File path: ql/src/test/queries/clientpositive/external_jdbc_table2.q
##########
@@ -7,43 +6,43 @@ CREATE TEMPORARY FUNCTION dboutput AS 'org.apache.hadoop.hive.contrib.genericudf
 
 FROM src
 SELECT
-dboutput ('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1;create=true','user1','passwd1',
+dboutput ('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1_1;create=true','user1','passwd1',

Review comment:
       Curious as to why this changed?

##########
File path: ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##########
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND "d_date_sk"
IS NOT NULL) A
             Reduce Operator Tree:
               Merge Join Operator
                 condition map:
-                     Anti Join 0 to 1
+                     Left Outer Join 0 to 1

Review comment:
       Got it, make sense

##########
File path: ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##########
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND "d_date_sk"
IS NOT NULL) A
             Reduce Operator Tree:
               Merge Join Operator
                 condition map:
-                     Anti Join 0 to 1
+                     Left Outer Join 0 to 1

Review comment:
       Also not sure what caused this change in plan.

##########
File path: ql/src/test/queries/clientpositive/external_jdbc_table2.q
##########
@@ -7,43 +6,43 @@ CREATE TEMPORARY FUNCTION dboutput AS 'org.apache.hadoop.hive.contrib.genericudf
 
 FROM src
 SELECT
-dboutput ('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1;create=true','user1','passwd1',
+dboutput ('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1_1;create=true','user1','passwd1',

Review comment:
       Curious as to why this changed?

##########
File path: ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##########
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND "d_date_sk"
IS NOT NULL) A
             Reduce Operator Tree:
               Merge Join Operator
                 condition map:
-                     Anti Join 0 to 1
+                     Left Outer Join 0 to 1

Review comment:
       Got it, make sense

##########
File path: ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##########
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND "d_date_sk"
IS NOT NULL) A
             Reduce Operator Tree:
               Merge Join Operator
                 condition map:
-                     Anti Join 0 to 1
+                     Left Outer Join 0 to 1

Review comment:
       Also not sure what caused this change in plan.

##########
File path: ql/src/test/queries/clientpositive/external_jdbc_table2.q
##########
@@ -7,43 +6,43 @@ CREATE TEMPORARY FUNCTION dboutput AS 'org.apache.hadoop.hive.contrib.genericudf
 
 FROM src
 SELECT
-dboutput ('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1;create=true','user1','passwd1',
+dboutput ('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1_1;create=true','user1','passwd1',

Review comment:
       Curious as to why this changed?

##########
File path: ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##########
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND "d_date_sk"
IS NOT NULL) A
             Reduce Operator Tree:
               Merge Join Operator
                 condition map:
-                     Anti Join 0 to 1
+                     Left Outer Join 0 to 1

Review comment:
       Got it, make sense

##########
File path: ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##########
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND "d_date_sk"
IS NOT NULL) A
             Reduce Operator Tree:
               Merge Join Operator
                 condition map:
-                     Anti Join 0 to 1
+                     Left Outer Join 0 to 1

Review comment:
       Also not sure what caused this change in plan.

##########
File path: ql/src/test/queries/clientpositive/external_jdbc_table2.q
##########
@@ -7,43 +6,43 @@ CREATE TEMPORARY FUNCTION dboutput AS 'org.apache.hadoop.hive.contrib.genericudf
 
 FROM src
 SELECT
-dboutput ('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1;create=true','user1','passwd1',
+dboutput ('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1_1;create=true','user1','passwd1',

Review comment:
       Curious as to why this changed?

##########
File path: ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##########
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND "d_date_sk"
IS NOT NULL) A
             Reduce Operator Tree:
               Merge Join Operator
                 condition map:
-                     Anti Join 0 to 1
+                     Left Outer Join 0 to 1

Review comment:
       Got it, make sense




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 483227)
    Time Spent: 2.5h  (was: 2h 20m)

> Include convention in JDBC converter operator in Calcite plan
> -------------------------------------------------------------
>
>                 Key: HIVE-24143
>                 URL: https://issues.apache.org/jira/browse/HIVE-24143
>             Project: Hive
>          Issue Type: Improvement
>          Components: CBO
>    Affects Versions: 4.0.0
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Among others, it will be useful to debug the dialect being chosen for query generation.
For instance:
> {code}
>  HiveProject(jdbc_type_conversion_table1.ikey=[$0], jdbc_type_conversion_table1.bkey=[$1],
jdbc_type_conversion_table1.fkey=[$2], jdbc_type_conversion_table1.dkey=[$3], jdbc_type_conversion_table1.chkey=[$4],
jdbc_type_conversion_table1.dekey=[$5], jdbc_type_conversion_table1.dtkey=[$6], jdbc_type_conversion_table1.tkey=[$7])
>   HiveProject(ikey=[$0], bkey=[$1], fkey=[$2], dkey=[$3], chkey=[$4], dekey=[$5], dtkey=[$6],
tkey=[$7])
> ----->    HiveJdbcConverter(convention=[JDBC.DERBY])
>       JdbcHiveTableScan(table=[[default, jdbc_type_conversion_table1]], table:alias=[jdbc_type_conversion_table1])
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message