hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-23443) LLAP speculative task pre-emption seems to be not working
Date Tue, 01 Sep 2020 00:48:01 GMT

     [ https://issues.apache.org/jira/browse/HIVE-23443?focusedWorklogId=476945&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-476945
]

ASF GitHub Bot logged work on HIVE-23443:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Sep/20 00:47
            Start Date: 01/Sep/20 00:47
    Worklog Time Spent: 10m 
      Work Description: github-actions[bot] commented on pull request #1012:
URL: https://github.com/apache/hive/pull/1012#issuecomment-684124264


   This pull request has been automatically marked as stale because it has not had recent
activity. It will be closed if no further activity occurs.
   Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 476945)
    Time Spent: 1h 20m  (was: 1h 10m)

> LLAP speculative task pre-emption seems to be not working
> ---------------------------------------------------------
>
>                 Key: HIVE-23443
>                 URL: https://issues.apache.org/jira/browse/HIVE-23443
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Prasanth Jayachandran
>            Assignee: Prasanth Jayachandran
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>         Attachments: HIVE-23443.1.patch, HIVE-23443.2.patch, HIVE-23443.3.patch
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> I think after HIVE-23210 we are getting a stable sort order and it is causing pre-emption
to not work in certain cases.
> {code:java}
> "attempt_1589167813851_0000_119_01_000008_0 (hive_20200511055921_89598f09-19f1-4969-ab7a-82e2dd796273-119/Map
1, started at 2020-05-11 05:59:22, in preemption queue, can finish)", 
> "attempt_1589167813851_0008_84_01_000008_1 (hive_20200511055928_7ae29ca3-e67d-4d1f-b193-05651023b503-84/Map
1, started at 2020-05-11 06:00:23, in preemption queue, can finish)" {code}
> Scheduler only peek's at the pre-emption queue and looks at whether it is non-finishable. 
> [https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java#L420]
> In the above case, all tasks are speculative but state change is not triggering pre-emption
queue re-ordering so peek() always returns canFinish task even though non-finishable tasks
are in the queue. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message