From issues-return-194797-archive-asf-public=cust-asf.ponee.io@hive.apache.org Wed Jul 1 05:05:02 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 17548180643 for ; Wed, 1 Jul 2020 07:05:02 +0200 (CEST) Received: (qmail 49861 invoked by uid 500); 1 Jul 2020 05:05:01 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 49835 invoked by uid 99); 1 Jul 2020 05:05:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jul 2020 05:05:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B0E6D48708 for ; Wed, 1 Jul 2020 05:05:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 33ACF78087E for ; Wed, 1 Jul 2020 05:05:00 +0000 (UTC) Date: Wed, 1 Jul 2020 05:05:00 +0000 (UTC) From: "ASF GitHub Bot (Jira)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (HIVE-23784) Fix Replication Metrics Sink to DB MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-23784?focusedWorklogId=453224&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453224 ] ASF GitHub Bot logged work on HIVE-23784: ----------------------------------------- Author: ASF GitHub Bot Created on: 01/Jul/20 05:04 Start Date: 01/Jul/20 05:04 Worklog Time Spent: 10m Work Description: pkumarsinha commented on a change in pull request #1193: URL: https://github.com/apache/hive/pull/1193#discussion_r448113867 ########## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/metric/MetricSink.java ########## @@ -64,8 +64,10 @@ public static MetricSink getInstance() { public synchronized void init(HiveConf conf) { if (!isInitialised) { this.conf = conf; - this.executorService.schedule(new MetricSinkWriter(conf), getFrequencyInSecs(), TimeUnit.SECONDS); + this.executorService.scheduleAtFixedRate(new MetricSinkWriter(conf), 0, + getFrequencyInSecs(), TimeUnit.SECONDS); Review comment: Frequency could be in Minutes only? Conversion to secs isn't required in getFrequencyInSecs() ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 453224) Remaining Estimate: 0h Time Spent: 10m > Fix Replication Metrics Sink to DB > ---------------------------------- > > Key: HIVE-23784 > URL: https://issues.apache.org/jira/browse/HIVE-23784 > Project: Hive > Issue Type: Task > Reporter: Aasha Medhi > Assignee: Aasha Medhi > Priority: Major > Attachments: HIVE-23784.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)