From issues-return-195673-archive-asf-public=cust-asf.ponee.io@hive.apache.org Wed Jul 15 09:20:04 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 990201804BB for ; Wed, 15 Jul 2020 11:20:04 +0200 (CEST) Received: (qmail 41239 invoked by uid 500); 15 Jul 2020 09:20:01 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 41164 invoked by uid 99); 15 Jul 2020 09:20:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Jul 2020 09:20:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9596440413 for ; Wed, 15 Jul 2020 09:20:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 14DC578027A for ; Wed, 15 Jul 2020 09:20:00 +0000 (UTC) Date: Wed, 15 Jul 2020 09:20:00 +0000 (UTC) From: "ASF GitHub Bot (Jira)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (HIVE-23069) Memory efficient iterator should be used during replication. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-23069?focusedWorklogId=459160&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-459160 ] ASF GitHub Bot logged work on HIVE-23069: ----------------------------------------- Author: ASF GitHub Bot Created on: 15/Jul/20 09:19 Start Date: 15/Jul/20 09:19 Worklog Time Spent: 10m Work Description: aasha commented on a change in pull request #1225: URL: https://github.com/apache/hive/pull/1225#discussion_r454912593 ########## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/io/FileOperations.java ########## @@ -165,4 +178,83 @@ private void validateSrcPathListExists() throws IOException, LoginException { throw new FileNotFoundException(FILE_NOT_FOUND.format(e.getMessage())); } } + + /** + * This needs the root data directory to which the data needs to be exported to. + * The data export here is a list of files either in table/partition that are written to the _files + * in the exportRootDataDir provided. + */ + void exportFilesAsList() throws SemanticException, IOException, LoginException { + if (dataPathList.isEmpty()) { + return; + } + Retry retryable = new Retry(IOException.class) { + @Override + public Void execute() throws Exception { + try (BufferedWriter writer = writer()) { + for (Path dataPath : dataPathList) { + writeFilesList(listFilesInDir(dataPath), writer, AcidUtils.getAcidSubDir(dataPath)); + } + } catch (IOException e) { + if (e instanceof FileNotFoundException) { Review comment: FileNotFoundException is an IOException and you have added retry for IOException. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 459160) Time Spent: 4h (was: 3h 50m) > Memory efficient iterator should be used during replication. > ------------------------------------------------------------ > > Key: HIVE-23069 > URL: https://issues.apache.org/jira/browse/HIVE-23069 > Project: Hive > Issue Type: Improvement > Reporter: Pravin Sinha > Assignee: Pravin Sinha > Priority: Major > Labels: pull-request-available > Attachments: HIVE-23069.01.patch, HIVE-23069.02.patch > > Time Spent: 4h > Remaining Estimate: 0h > > Currently the iterator used while copying table data is memory based. In case of a database with very large number of table/partitions, such iterator may cause HS2 process to go OOM. > Also introduces a config option to run data copy tasks during repl load operation. -- This message was sent by Atlassian Jira (v8.3.4#803005)