hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-23849) Hive skips the creation of ColumnAccessInfo when creating a view
Date Wed, 22 Jul 2020 09:00:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-23849?focusedWorklogId=461912&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-461912
]

ASF GitHub Bot logged work on HIVE-23849:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Jul/20 08:59
            Start Date: 22/Jul/20 08:59
    Worklog Time Spent: 10m 
      Work Description: bmaidics commented on a change in pull request #1263:
URL: https://github.com/apache/hive/pull/1263#discussion_r458643492



##########
File path: ql/src/test/results/clientpositive/llap/ppd_deterministic_expr.q.out
##########
@@ -198,6 +198,9 @@ PREHOOK: query: create view viewDeterministicUDFA partitioned on (vpart1,
vpart2
 where part1 in ('US', 'CA')
 PREHOOK: type: CREATEVIEW
 PREHOOK: Input: default@testa
+PREHOOK: Input: default@testa@part1=CA/part2=ABC/part3=300

Review comment:
       @jcamachor , I think this behavior is expected. Since in this test, CBO is disabled,
ColumnAccessInfo will be null, so on view creation, we'll run step 6-8 after my change. Step
7 is the optimizer, and it runs SimpleFetchOptimizer, which will add these partitions to read
from them. Is this answers your concern, or maybe I misunderstood your question?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 461912)
    Time Spent: 2h  (was: 1h 50m)

> Hive skips the creation of ColumnAccessInfo when creating a view
> ----------------------------------------------------------------
>
>                 Key: HIVE-23849
>                 URL: https://issues.apache.org/jira/browse/HIVE-23849
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Barnabas Maidics
>            Assignee: Barnabas Maidics
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> When creating a view, Hive skips the creation of ColumnAccessInfo that should be created
at [step 8|#L12601]. This causes Authorization error. 
> Currently, this issue is "hidden" when CBO is enabled. By introducing HIVE-14496, CalcitePlanner
creates this ColumnAccessInfo at [step 2|https://github.com/apache/hive/blob/11e069b277fd1a18899b8ca1d2926fcbe73f17f2/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java#L12459].
But after turning off CBO, the issue is still there. 
> I think the return statement in [step 5|https://github.com/apache/hive/blob/11e069b277fd1a18899b8ca1d2926fcbe73f17f2/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java#L12574] is
not necessary.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message