hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-23789) Merge ValidTxnManager into DriverTxnHandler
Date Wed, 01 Jul 2020 08:08:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-23789?focusedWorklogId=453289&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453289
]

ASF GitHub Bot logged work on HIVE-23789:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Jul/20 08:07
            Start Date: 01/Jul/20 08:07
    Worklog Time Spent: 10m 
      Work Description: miklosgergely commented on a change in pull request #1194:
URL: https://github.com/apache/hive/pull/1194#discussion_r448190290



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/Compiler.java
##########
@@ -188,7 +188,6 @@ private BaseSemanticAnalyzer analyze() throws Exception {
     // because at that point we need access to the objects.
     Hive.get().getMSC().flushCache();
 
-    driverContext.setBackupContext(new Context(context));

Review comment:
       The usage of backupContext was removed by Peter Varga recently (https://github.com/apache/hive/commit/e2a02f1b43cba657d4d1c16ead091072be5fe834#diff-71a166c053d9c698f9cb64eaef832aff),
I've asked him to confirm, and it was intentional. After this change we are only setting the
backup context here, but it is never used.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 453289)
    Time Spent: 0.5h  (was: 20m)

> Merge ValidTxnManager into DriverTxnHandler
> -------------------------------------------
>
>                 Key: HIVE-23789
>                 URL: https://issues.apache.org/jira/browse/HIVE-23789
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message