hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-23784) Fix Replication Metrics Sink to DB
Date Wed, 01 Jul 2020 05:05:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-23784?focusedWorklogId=453224&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453224
]

ASF GitHub Bot logged work on HIVE-23784:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Jul/20 05:04
            Start Date: 01/Jul/20 05:04
    Worklog Time Spent: 10m 
      Work Description: pkumarsinha commented on a change in pull request #1193:
URL: https://github.com/apache/hive/pull/1193#discussion_r448113867



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/metric/MetricSink.java
##########
@@ -64,8 +64,10 @@ public static MetricSink getInstance() {
   public synchronized void init(HiveConf conf) {
     if (!isInitialised) {
       this.conf = conf;
-      this.executorService.schedule(new MetricSinkWriter(conf), getFrequencyInSecs(), TimeUnit.SECONDS);
+      this.executorService.scheduleAtFixedRate(new MetricSinkWriter(conf), 0,
+        getFrequencyInSecs(), TimeUnit.SECONDS);

Review comment:
       Frequency could be in Minutes only? Conversion to secs isn't required in getFrequencyInSecs()




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 453224)
    Remaining Estimate: 0h
            Time Spent: 10m

> Fix Replication Metrics Sink to DB
> ----------------------------------
>
>                 Key: HIVE-23784
>                 URL: https://issues.apache.org/jira/browse/HIVE-23784
>             Project: Hive
>          Issue Type: Task
>            Reporter: Aasha Medhi
>            Assignee: Aasha Medhi
>            Priority: Major
>         Attachments: HIVE-23784.01.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message