hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-16490) Hive should not use private HDFS APIs for encryption
Date Mon, 20 Jul 2020 20:07:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-16490?focusedWorklogId=461246&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-461246
]

ASF GitHub Bot logged work on HIVE-16490:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Jul/20 20:06
            Start Date: 20/Jul/20 20:06
    Worklog Time Spent: 10m 
      Work Description: umamaheswararao commented on a change in pull request #1279:
URL: https://github.com/apache/hive/pull/1279#discussion_r457661391



##########
File path: shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java
##########
@@ -1223,11 +1223,31 @@ public static boolean isHdfsEncryptionSupported() {
     private final Configuration conf;
 
     public HdfsEncryptionShim(URI uri, Configuration conf) throws IOException {
-      DistributedFileSystem dfs = (DistributedFileSystem)FileSystem.get(uri, conf);
-
       this.conf = conf;
-      this.keyProvider = dfs.getClient().getKeyProvider();
       this.hdfsAdmin = new HdfsAdmin(uri, conf);
+      this.keyProvider = getKeyProvider();
+    }
+
+    private KeyProvider getKeyProvider() throws IOException {
+      if (isMethodExist(HdfsAdmin.class, "getKeyProvider")) {

Review comment:
       That is great. I will remove that then. Thanks for pointing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 461246)
    Time Spent: 0.5h  (was: 20m)

> Hive should not use private HDFS APIs for encryption
> ----------------------------------------------------
>
>                 Key: HIVE-16490
>                 URL: https://issues.apache.org/jira/browse/HIVE-16490
>             Project: Hive
>          Issue Type: Improvement
>          Components: Encryption
>    Affects Versions: 2.2.0
>            Reporter: Andrew Wang
>            Assignee: Naveen Gangam
>            Priority: Critical
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> When compiling against bleeding edge versions of Hive and Hadoop, we discovered that
HIVE-16047 references a private HDFS API, DFSClient, to get at various encryption related
information. The private API was recently changed by HADOOP-14104, which broke Hive compilation.
> It'd be better to instead use publicly supported APIs. HDFS-11687 has been filed to add
whatever encryption APIs are needed by Hive. This JIRA is to move Hive over to these new APIs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message