From issues-return-193645-archive-asf-public=cust-asf.ponee.io@hive.apache.org Tue Jun 16 13:24:02 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E7F51180621 for ; Tue, 16 Jun 2020 15:24:01 +0200 (CEST) Received: (qmail 52761 invoked by uid 500); 16 Jun 2020 13:24:01 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 52750 invoked by uid 99); 16 Jun 2020 13:24:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jun 2020 13:24:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8FFFD41536 for ; Tue, 16 Jun 2020 13:24:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 0FE38780410 for ; Tue, 16 Jun 2020 13:24:00 +0000 (UTC) Date: Tue, 16 Jun 2020 13:24:00 +0000 (UTC) From: "ASF GitHub Bot (Jira)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (HIVE-23592) Routine "makeIntPair" is Not Correct MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-23592?focusedWorklogId=446506&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446506 ] ASF GitHub Bot logged work on HIVE-23592: ----------------------------------------- Author: ASF GitHub Bot Created on: 16/Jun/20 13:23 Start Date: 16/Jun/20 13:23 Worklog Time Spent: 10m Work Description: belugabehr merged pull request #1052: URL: https://github.com/apache/hive/pull/1052 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 446506) Time Spent: 1h 40m (was: 1.5h) > Routine "makeIntPair" is Not Correct > ------------------------------------ > > Key: HIVE-23592 > URL: https://issues.apache.org/jira/browse/HIVE-23592 > Project: Hive > Issue Type: Bug > Components: llap > Affects Versions: 3.2.0 > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Minor > Labels: pull-request-available > Time Spent: 1h 40m > Remaining Estimate: 0h > > {code:java|title=BuddyAllocator.java} > // Utility methods used to store pairs of ints as long. > private static long makeIntPair(int first, int second) { > return ((long)first) << 32 | second; > } > private static int getFirstInt(long result) { > return (int) (result >>> 32); > } > private static int getSecondInt(long result) { > return (int) (result & ((1L << 32) - 1)); > } > {code} > {code:java} > long result = LLAP.makeIntPair(Integer.MIN_VALUE, Integer.MIN_VALUE); > if (LLAP.getFirstInt(result) != Integer.MIN_VALUE) { > throw new Exception(); > } > if (LLAP.getSecondInt(result) != Integer.MIN_VALUE) { > throw new Exception(); > } > /* > * Exception in thread "main" java.lang.Exception > * at org.test.TestMe.main(TestMe.java:19) > */ > {code} > [https://github.com/apache/hive/blob/4b670877c280b37c5776046f66d766079489b2a8/llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java#L1677] -- This message was sent by Atlassian Jira (v8.3.4#803005)